Closed Bug 1145894 Opened 10 years ago Closed 2 years ago

TreeModel in profiler does not correctly identify platform content loaded via file:/// when running local build

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: jsantell, Unassigned)

References

Details

Attachments

(1 file)

Due to how we detect content, being no category, not having a chrome URL, and having a http:// or file:// protocol, when running locally, using a chrome JS (no category) in gecko, coming from file:// where my gecko-dev checkout lives, this passes the tests. See attachment
Check out http://todomvc.com/examples/react/#/, as there's a lot of nsAutoComplete stuff.
I guess new pseudo stack entries were added without a category :/ We need to ask reviewers to r- such patches.
Oh, now I see the screenshot in more detail and that's not a psentry. I saw nsAutoComplete and immediately assume a pseudo stack. Ignore comment 2.
Blocks: 1147945
No longer blocks: 1147945
Shu, is this a profiler issue for not being correctly tagged as platform code? Ran into this a few more times when working with source maps (as these look like local files), and appears to be certain files maybe loaded from file:// rather than resource/chrome.
This can be reproduced by recording on a new tab, as pretty much all content should be platform content, but we get a handful of frames from `file://{path-to-my-gecko-checkout}/obj.noindex/dist/Nightly.app/...` -- I wonder if we can just say if the URI is "dist/Nightly.app/Contents/Resources/components" (for each operating system), or if these scripts should be served over resource:// in the first place.
Summary: TreeModel in profiler does not correctly filter out platform content when running local build → TreeModel in profiler does not correctly identify platform content loaded via file:/// when running local build
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
OS: Mac OS X → Unspecified
Priority: -- → P3
Hardware: x86 → Unspecified
Version: 37 Branch → unspecified
Product: Firefox → DevTools
Severity: normal → S3

This report is related to the old DevTools Profiler.
The Performance panel now points to the new Firefox profiler available at profiler.firefox.com
Closing as Invalid bug

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: