Closed
Bug 1146331
Opened 10 years ago
Closed 9 years ago
In-content Preferences - Don't allow text selection of titlebars of subdialogs
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: mkaply, Assigned: ma.steiman, Mentored)
References
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file)
|
(deleted),
patch
|
Gijs
:
review+
ntim
:
feedback+
|
Details | Diff | Splinter Review |
When you open one of the in-content preferences dialogs (Security Exceptions for example), you can highlight the text in the titlebar.
This makes it feel like a web page, not a dialog The text of the titlebar should not be able to be highlighted.
|
||
Updated•10 years ago
|
Blocks: 718011
Summary: In-content Preferences - Don't allow highlighting of titlebars → In-content Preferences - Don't allow highlighting of titlebars of subdialogs
|
||
Comment 1•9 years ago
|
||
Adding -moz-user-select: none; here : http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/incontentprefs/preferences.inc.css#323 should do the trick.
Mentor: ntim.bugs
OS: Windows 7 → Unspecified
Hardware: x86_64 → Unspecified
Summary: In-content Preferences - Don't allow highlighting of titlebars of subdialogs → In-content Preferences - Don't allow text selection of titlebars of subdialogs
Whiteboard: [good first bug][lang=css]
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ma.steiman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
After applying this patch I was indeed no longer able to highlight the titlebar. Tim, if you're not a reviewer please let me know so we can push this along. Thanks!!!
Flags: needinfo?(ntim.bugs)
Attachment #8621975 -
Flags: review?(ntim.bugs)
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8621975 [details] [diff] [review]
Removes text highlight ability in titlebar in in-content preference windows
Thanks for the patch !
I'm indeed not a reviewer, but the patch looks good to me.
Flags: needinfo?(ntim.bugs)
Attachment #8621975 -
Flags: review?(ntim.bugs)
Attachment #8621975 -
Flags: review?(dao)
Attachment #8621975 -
Flags: feedback+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8621975 [details] [diff] [review]
Removes text highlight ability in titlebar in in-content preference windows
Review of attachment 8621975 [details] [diff] [review]:
-----------------------------------------------------------------
This removes the user's ability to highlight titlebar in in-content preference windows
Attachment #8621975 -
Flags: review?(dao) → review?(gavin.sharp)
|
|
||
Updated•9 years ago
|
Attachment #8621975 -
Flags: review?(gavin.sharp) → review?(gijskruitbosch+bugs)
|
||
Updated•9 years ago
|
Attachment #8621975 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 5•9 years ago
|
||
The checkin-needed keyword will get your patch checked in, once the patch reaches mozilla-central, it will be in Nightly the next day. Let me know if you want me to suggest some other bugs :)
Keywords: checkin-needed
Keywords: checkin-needed
|
|
Assignee | |
Comment 7•9 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #5)
> The checkin-needed keyword will get your patch checked in, once the patch
> reaches mozilla-central, it will be in Nightly the next day. Let me know if
> you want me to suggest some other bugs :)
Great! I would love more bug suggestions, I'm here to learn!
Flags: needinfo?(ntim.bugs)
|
|
||
Comment 8•9 years ago
|
||
(In reply to Muhsin A. Steiman from comment #7)
> (In reply to Tim Nguyen [:ntim] from comment #5)
> > The checkin-needed keyword will get your patch checked in, once the patch
> > reaches mozilla-central, it will be in Nightly the next day. Let me know if
> > you want me to suggest some other bugs :)
>
> Great! I would love more bug suggestions, I'm here to learn!
Here are some other bugs :
Easy ones : bug 1169884, bug 940275, bug 1173504, bug 937358, bug 877697
If you want more challenging bugs : bug 1106114, bug 1099234, bug 734326
Flags: needinfo?(ntim.bugs)
|
||
Comment 9•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
You need to log in
before you can comment on or make changes to this bug.
Description
•