Open Bug 1146490 Opened 10 years ago Updated 2 years ago

Switching tabs with the keyboard doesn't hide tooltips

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: wbamberg, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [btpp-backlog])

Attachments

(2 files)

Attached image switch-bug.gif (deleted) —
If I have the Inspector open, show a tooltip (by, for example, clicking on a color swatch), then switch to a different tab using the keyboard, the tooltip is not hidden, when it probably should be (since the tooltip content is usually specific to the tab we are looking at).

I've attached a gif to show what I mean.

It seems to be possible to fix this with code like:

***
// hide the tooltip if the user switches tabs while it's open
let browserWindow = Services.wm.getMostRecentWindow(BROWSER_WINDOW);
browserWindow.addEventListener("TabSelect", hideTooltips, false);

...

function hideTooltips() {
  // hide all the tooltips
}
***

...perhaps in https://dxr.mozilla.org/mozilla-central/source/browser/devtools/styleinspector/style-inspector-overlays.js? This file already has a function that hides all the tooltips: https://dxr.mozilla.org/mozilla-central/source/browser/devtools/styleinspector/style-inspector-overlays.js#380, maybe we could reuse that?

I've attached a patch that does this. But there might be a better way?
Info from bug 1171452:
This also happens if you press  Ctrl+[  or  Ctrl+]  or Ctrl+Shift+O to switch to another devtools tab.
OS: Mac OS X → All
Hardware: x86 → All
Inspector bug triage. Filter on CLIMBING SHOES
Priority: -- → P3
Whiteboard: [btpp-backlog]
Product: Firefox → DevTools
Severity: normal → S3

The severity field for this bug is relatively low, S3. However, the bug has 5 duplicates.
:jdescottes, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jdescottes)

P3/S3 sounds fine here. This is not really breaking anything, it also doesn't affect all tooltips, only the ones which can overflow the toolbox, eg the color picker one.

Flags: needinfo?(jdescottes)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: