We already did the move to BindTextureSource where it matters for performance. Now let's move the other classes so that we can remove GetTextureSource entirely since having both is confusing and risky (GetTextureSources will just not work with gralloc textures, for example).

Comment on attachment 8582406 [details] [diff] [review] patch Review of attachment 8582406 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/d3d11/TextureD3D11.h @@ +243,5 @@ > public: > DXGITextureHostD3D11(TextureFlags aFlags, > const SurfaceDescriptorD3D10& aDescriptor); > > + virtual TextureSource* BindTextureSource(CompositableTextureSourceRef& aTexture) override; Should't this be bool type? ::: gfx/layers/d3d9/TextureD3D9.h @@ +297,5 @@ > public: > TextureHostD3D9(TextureFlags aFlags, > const SurfaceDescriptorD3D9& aDescriptor); > > + virtual TextureSource* BindTextureSource(CompositableTextureSourceRef& aTexture) override; Should't this be bool tyep? @@ +338,5 @@ > public: > DXGITextureHostD3D9(TextureFlags aFlags, > const SurfaceDescriptorD3D10& aDescriptor); > > + virtual TextureSource* BindTextureSource(CompositableTextureSourceRef& aTexture) override; Shouldn't this be bool type?

(In reply to Sotaro Ikeda [:sotaro] from comment #2) > > Shouldn't this be bool type? Yeah, The patch is running on try at the moment to catch the mistakes I made on files that are not built on linux, hopefully there aren't too many of them.

Fixes build failures on windows and mac.

Comment on attachment 8583160 [details] [diff] [review] v2 Review of attachment 8583160 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.