Closed
Bug 1147040
Opened 9 years ago
Closed 9 years ago
[Customizer] Wait for DOMContentLoaded before initializing
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
Some of the components expect `document.documentElement` to be defined when they load (such as gaia-icons). Wrapping the Customizer initialization in DOMContentLoaded should prevent these sorts of JS errors:
W/FM Radio(11735): [JavaScript Error: "TypeError: document.documentElement is null" {file: "app://customizer.gaiamobile.org/js/addon-concat.js" line: 3031}]
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Comment 1•9 years ago
|
||
Sorry this PR is ugly and lengthy for such a small change. Pretty much the entire file had to be indented.
Attachment #8582547 -
Flags: review?(drs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8582547 [details] pull-request (master) If this happens again, you can give people this link: https://github.com/fxos/customizer/pull/15/files?w=1
Attachment #8582547 -
Flags: review?(drs) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Landed on master: https://github.com/fxos/customizer/commit/94f9a864fb6269c162f03c5108e8af69e911b758
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Whiteboard: [lightsaber] → [ignite]
|
|
||
Updated•9 years ago
|
Whiteboard: [ignite] → [spark]
You need to log in
before you can comment on or make changes to this bug.
Description
•