Add more guidance notes for the localizers. Add links to acronym definitions where appropriate.

Comment on attachment 8583448 [details] [diff] [review] Update L10n translation notes for about:webrtc Review of attachment 8583448 [details] [diff] [review]: ----------------------------------------------------------------- The localization comments look great, thanks. It would be a f+ for that. What I'm not really understanding (hence the f-) is why you changed all the string IDs from using underscore to camel case. Is that a requirement? Because otherwise you're asking a few locales to re-translate the entire file at this point. If it's needed for consistency I'll bite the bullet, otherwise I'd keep the original IDs. ::: toolkit/locales/en-US/chrome/global/aboutWebrtc.properties @@ +2,5 @@ > # License, v. 2.0. If a copy of the MPL was not distributed with this > # file, You can obtain one at http://mozilla.org/MPL/2.0/. > > +# LOCALIZATION NOTE (documentTitle, cannotRetrieveLog): > +# The text "WebRTC" is a proper noun should not be translated. "and" should not be translated @@ +21,5 @@ > +debugLogAt = log can be found at: %1$S > + > +# LOCALIZATION NOTE (debugActive): > +# %1$S will be replaced by the full path debug log file name. > +debugActive = debug mode active, writing trace messages to: %1$S Should this be "in" instead of "to" for consistency with other strings? @@ +85,2 @@ > local = local > remote = remote What's the noun reference for these two adjectives? @@ +89,3 @@ > priority = Priority > nominated = Nominated > selected = Selected Same here: what's the noun reference for these two adjectives?

The change of identifier format was to more closely follow the referenced example file. I did not understand it would already cause issues in the l10n operation. It's simple to put back before landing.

incorporated feedback comments

Comment on attachment 8583896 [details] [diff] [review] Update L10n translation notes for about:webrtc Review of attachment 8583896 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, it looks great! I'm switching to f+ because this should be double checked and formally reviewed by an actual product peer.

Comment on attachment 8583896 [details] [diff] [review] Update L10n translation notes for about:webrtc Mike, This is a follow-on patch that focused on the properties file format. (An issue that you also raised during the main review.) Nothing else has changed.

Comment on attachment 8583896 [details] [diff] [review] Update L10n translation notes for about:webrtc Review of attachment 8583896 [details] [diff] [review]: ----------------------------------------------------------------- Well, this is as clear as localization comments can get, I guess. Awesome! There are three nits left; so small that I didn't even go through the trouble of calling them out as such! ::: toolkit/locales/en-US/chrome/global/aboutWebrtc.properties @@ +8,5 @@ > document_title = WebRTC Internals > +cannot_retrieve_log = Cannot retrieve WebRTC log data > + > +# LOCALIZATION NOTE (save_page_msg): > +# - %1$S will be replaced by a full path file name: the target of the SavePage operation. s/- // @@ +25,5 @@ > +debug_mode_on_state_msg = debug mode active, trace log at: %1$S > + > +# LOCALIZATION NOTE (aec_logging_msg_label, aec_logging_off_state_label, > +# aec_logging_on_state_label, aec_logging_on_state_msg): > +# AEC as an abbreviation for Acoustic Echo Cancellation. s/as/is/ @@ +33,5 @@ > +aec_logging_on_state_msg = AEC logging active (speak with the caller for a few minutes and then stop the capture) > + > +# LOCALIZATION NOTE (aec_logging_off_state_msg): > +# %1$S will be replaced by the full path to the directory containing the captured log files. > +# AEC as an abbreviation for Acoustic Echo Cancellation. s/as/is/

Comment on attachment 8584087 [details] [diff] [review] Update L10n translation notes for about:webrtc Carry forward francesco.lodolo: feedback+, mdeboer: review+