Samael Wang [:freesamael] (away for now) Assignee
	Description • 10 years ago

1. Map the preference "mms.debugging.enabled" to a corresponding setting so it can be added to Settings menu later.
2. Update MmsService / SmsService to reflect runtime setting / preference changes.

	Wesley Huang [:wesley_huang] (EPM) (NI me)
	Comment 1 • 10 years ago

[Tracking Requested - why for this release]:

	Bevis Tseng[:bevis][:btseng](Exited)
	Comment 3 • 10 years ago

Comment on attachment 8593870 [details] [diff] [review]
Map settings "mms.debugging.enabled" to preference

Review of attachment 8593870 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/gonk/MmsService.js
@@ +1532,5 @@
> +    let debugPref = false;
> +    try {
> +      DEBUG = debugPref || Services.prefs.getBoolPref(kPrefMmsDebuggingEnabled);
> +    } catch (e) {}
> +  },

We already have default value set in line#19.
We can simplify this as followed, don't we?
    try {
      DEBUG = Services.prefs.getBoolPref(kPrefMmsDebuggingEnabled);
    } catch (e) {}

	Bevis Tseng[:bevis][:btseng](Exited)
	Comment 4 • 10 years ago

Comment on attachment 8593870 [details] [diff] [review]
Map settings "mms.debugging.enabled" to preference

Review of attachment 8593870 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the comment addressed.

Thanks!

	Ryan VanderMeulen [:RyanVM]
	Comment 6 • 10 years ago

https://hg.mozilla.org/integration/b2g-inbound/rev/b2666b51ce73

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/b2666b51ce73