Closed
Bug 1147679
Opened 10 years ago
Closed 9 years ago
Consider using PR_GetFileInfo64 when deserializing heap snapshots
Categories
(DevTools :: Memory, defect)
Tracking
(firefox41 fixed)
RESOLVED
FIXED
Firefox 41
| Tracking | Status | |
|---|---|---|
| firefox41 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
> ::: toolkit/devtools/server/ChromeUtils.cpp
> @@ +404,5 @@
> > + return nullptr;
> > + }
> > +
> > + PRFileInfo fileInfo;
> > + if (PR_GetFileInfo(path.get(), &fileInfo) != PR_SUCCESS) {
>
> For the future: consider using PR_GetFileInfo64 (and dealing with issues of
> conversion to size_t on 32-bit machines).
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8614890 -
Flags: review?(jimb)
|
||
Updated•9 years ago
|
Attachment #8614890 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•