Open Bug 1147841 Opened 10 years ago Updated 2 years ago

Remove ipc.json

Categories

(Testing :: Mochitest, defect)

defect

Tracking

(Not tracked)

People

(Reporter: vaibhav1994, Unassigned)

References

Details

Blocks: 1144573
Hi Shih-Chiang Chien, .json formats have now become old and we have shifted to the new manifest .ini format. So, I was trying to remove ipc.json, and I saw that it is used in: 1) https://dxr.mozilla.org/mozilla-central/source/dom/media/tests/mochitest/ipc/test_ipc.html#152 2) https://dxr.mozilla.org/mozilla-central/source/dom/devicestorage/ipc/test_ipc.html I was wondering whether test_ipc.html is relevant now and if we can remove it. If we cannot, then could you let me know how to proceed by removing .json files and instead directly append those tests?
Flags: needinfo?(schien)
we run a lot of tests in e10s mode now, so this could be duplicated tests, maybe not though.
Currently mochitest-e10s only runs on Linux so we cannot remove test_ipc.html at current stage. we use .json to exclude those unstable test cases. Can we do the same thing in the new manifest .ini format?
Flags: needinfo?(schien)
possibly we could use moz.build to copy the test files into the ipc/ subdir. Presumably the test_ipc.html is just a wrapper that forces into ipc mode- maybe this is better suited for when we are running mochitest-plain in e10s mode on windows/osx.
regarding: https://dxr.mozilla.org/mozilla-central/source/dom/canvas/test/android.json, is it possible we could just remove that file? I do not see it referenced anywhere.
Yes, I have seen that android.json file and the test present there is not in the tree anymore. I am planning to remove it in the whole patch. I am still not sure how to remove ipc.json without breaking the functionality. test_ipc.html uses the tests specified in the .json file to either run those or exclude those, but I don't think we can do the same in .ini files, can we?
we could get creative with test_ipc.html, or wait until mochitest-plain is running on e10s for osx and windows. Jim, do you know the general timeline for getting mochitest-plain e10s tests running in automation for windows and osx?
Flags: needinfo?(jmathies)
(In reply to Joel Maher (:jmaher) from comment #7) > we could get creative with test_ipc.html, or wait until mochitest-plain is > running on e10s for osx and windows. > > Jim, do you know the general timeline for getting mochitest-plain e10s tests > running in automation for windows and osx? Windows should be enabled here as soon as we can get to it in bug 1122901. OSX tests are a mess, not sure when we'll get to those.
Flags: needinfo?(jmathies)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.