Open Bug 1147955 Opened 10 years ago Updated 2 years ago

Link jquery-bound events to the user's code, not the jquery code in debugger panel

Categories

(DevTools :: Debugger, enhancement, P3)

36 Branch
x86
macOS
enhancement

Tracking

(Not tracked)

People

(Reporter: canuckistani, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [platform-rel-jQuery] )

Attachments

(1 file)

In the debugger's events panel it would be great to derive the place in the user's code where they do $(selector).click(fn) ...instead of landing the user in jquery.js line 4000: return typeof jQuery !== strundefined && jQuery.event.triggered !== e.type ? jQuery.event.dispatch.apply( elem,arguments ) : undefined; The jquery event handling in the inspector knows how to figure this out. The workaround is: 1. find the element the event is bound to in the DOM 2. click on the event button 3. click on the 'pause' button to jump to the code
Attached image Users code in the event popup (deleted) —
Sure this is still valid? At least in Nightly, in the event popup you get at least two events, both click: * one is the custom user code (top in the screenshot, with a "jQuery" mark * below this one is the jquery one Isn't this what the ticket here asks for?
Flags: needinfo?(jgriffiths)
(In reply to Jens from comment #1) > Created attachment 8741788 [details] > Users code in the event popup > > Sure this is still valid? At least in Nightly, in the event popup you get at > least two events, both click: > * one is the custom user code (top in the screenshot, with a "jQuery" mark > * below this one is the jquery one > > Isn't this what the ticket here asks for? No, in the submission is say "In the debugger's events panel" meaning the panel where we expose events in the *debugger*, not the event pop-up in the *inspector*
Flags: needinfo?(jgriffiths)
Summary: Link jquery-bound events to the user's code, not the jquery code → Link jquery-bound events to the user's code, not the jquery code in debugger panel
Whiteboard: [platform-rel-jQuery]
platform-rel: --- → ?
platform-rel: ? → ---
Product: Firefox → DevTools

Honza, could you see if this is still relevant?

Flags: needinfo?(odvarko)
Whiteboard: [platform-rel-jQuery] → [platform-rel-jQuery] needs-review

This is related to the old Events panel (available in the previous Debugger UI). But, we want this in the new Event's panel implementation. So, I am keeping this opened.

David, feel free to close if we don't need report for this feature (e.g. we already have one that covers this).

Honza

Flags: needinfo?(odvarko)
Whiteboard: [platform-rel-jQuery] needs-review → [platform-rel-jQuery]
Blocks: 1565711
Blocks: 1565713
No longer blocks: 1565711
No longer blocks: 1565713
Type: defect → enhancement
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: