Closed
Bug 1148012
Opened 10 years ago
Closed 10 years ago
Add a run ID to NPAPI plugins.
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(e10sm6+, firefox40 fixed)
RESOLVED
FIXED
mozilla40
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(3 files, 1 obsolete file)
Split out from bug 1110887.
In order to differentiate different "runs" of a plugin process, I propose adding a run ID that can be exposed via nsIObjectLoadingContent. This is necessary for the plugin crash UI work I'm doing in bug 1110887.
While the run ID seems to serve the same purpose as the process ID, I felt like the process ID is too much of a system-level bit of data to expose to chrome-level JS.
Assignee | ||
Comment 1•10 years ago
|
||
/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=?
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?
Pull down these commits:
hg pull review -r 2c405f53cc691446b6dfbae1fb7ea194ba18e674
Assignee | ||
Updated•10 years ago
|
Attachment #8583955 -
Flags: review?(jocheng)
Attachment #8583955 -
Flags: review?(jmathies)
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=?
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?
Pull down these commits:
hg pull review -r 2c405f53cc691446b6dfbae1fb7ea194ba18e674
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=?
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?
Pull down these commits:
hg pull review -r 2c405f53cc691446b6dfbae1fb7ea194ba18e674
Attachment #8583955 -
Flags: review?(jocheng) → review?(joshmoz)
Assignee | ||
Comment 4•10 years ago
|
||
Hey Josh - additional context for this is in bug 1110887 comment 10 and bug 1110887 comment 12.
Assignee | ||
Comment 5•10 years ago
|
||
https://reviewboard.mozilla.org/r/6165/#review5163
::: dom/base/nsObjectLoadingContent.cpp
(Diff revision 1)
> + if (NS_WARN_IF(!aRunID) {
Bah - goofed here in a refactor. Missing a closing parenthesis - I'll update the patch...
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=?
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?
Pull down these commits:
hg pull review -r 05cffc803255f549feeee8aa96a6df6ade4247ff
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
https://reviewboard.mozilla.org/r/6161/#review5265
::: dom/plugins/base/nsNPAPIPluginInstance.cpp
(Diff revision 2)
> + return NS_ERROR_FAILURE;
Always use {} for if blocks in this code.
::: dom/plugins/base/nsNPAPIPluginInstance.cpp
(Diff revision 2)
> + PluginLibrary* library = mPlugin->GetLibrary();
Probably best to check that mPlugin is not null.
Attachment #8583955 -
Flags: review?(joshmoz)
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=jimm.
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?
Pull down these commits:
hg pull review -r a19ce82f52e61cd4f9361ee7f9afea5ca1ed6748
Attachment #8583955 -
Flags: review?(jmathies) → review?(joshmoz)
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
https://reviewboard.mozilla.org/r/6161/#review5499
Attachment #8583955 -
Flags: review?(joshmoz) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=jimm.
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?
Pull down these commits:
hg pull review -r a19ce82f52e61cd4f9361ee7f9afea5ca1ed6748
Attachment #8583955 -
Flags: review?(mrbkap)
Attachment #8583955 -
Flags: review?(joshmoz)
Attachment #8583955 -
Flags: review+
Assignee | ||
Comment 11•10 years ago
|
||
I hit this when trying to push to inbound:
remote: ************************** ERROR ****************************
remote:
remote: WebIDL file dom/webidl/HTMLObjectElement.webidl altered in changeset 7ae748601cc4 without DOM peer review
remote:
remote:
remote: Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
remote: This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..
remote:
remote: *************************************************************
And I believe mrbkap is a DOM peer.
Assignee | ||
Updated•10 years ago
|
Attachment #8583955 -
Flags: review?(joshmoz)
Comment 12•10 years ago
|
||
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
r+ for the .webidl change.
Attachment #8583955 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Attachment #8583955 -
Flags: review?(mrbkap)
Attachment #8583955 -
Flags: review+
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley
/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=jimm.
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?
Pull down these commits:
hg pull review -r a19ce82f52e61cd4f9361ee7f9afea5ca1ed6748
Assignee | ||
Comment 14•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a423c6fdc3d4
https://hg.mozilla.org/mozilla-central/rev/fb8373ac7558
https://hg.mozilla.org/mozilla-central/rev/84d46805a079
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 16•9 years ago
|
||
Attachment #8583955 -
Attachment is obsolete: true
Assignee | ||
Comment 17•9 years ago
|
||
Assignee | ||
Comment 18•9 years ago
|
||
Assignee | ||
Comment 19•9 years ago
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•