Closed
Bug 1148139
Opened 10 years ago
Closed 10 years ago
[Customizer] Inline stylesheets in JavaScript
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
Currently, stylesheets are unable to be injected into addons asynchronously. To work around this issue, we can inline the CSS in JavaScript for the Customizer.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8584169 -
Flags: review?(drs)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8584169 [details]
pull-request (master)
See my comments on the PR. Might be fine, but let's talk about it first.
Attachment #8584169 -
Flags: review?(drs) → review-
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8584169 [details]
pull-request (master)
I addressed your comments in the PR where possible and commented on some others (we can't comment out something in the .webapp manifest afaik). Let me know if there's anything else you want to discuss further. Thanks!
Attachment #8584169 -
Flags: review- → review?(drs)
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8584169 [details]
pull-request (master)
Looks good. I left one last comment on the PR.
Attachment #8584169 -
Flags: review?(drs) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Landed on master:
https://github.com/fxos/customizer/commit/20b72991b51cc634f4998ecd8921254538cfea61
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
|
||
Updated•10 years ago
|
Whiteboard: [lightsaber] → [ignite]
|
|
||
Updated•10 years ago
|
Whiteboard: [ignite] → [spark]
You need to log in
before you can comment on or make changes to this bug.
Description
•