Closed
Bug 1148191
Opened 10 years ago
Closed 10 years ago
getURLAndPostDataForKeyword() is deprecated, please use PlacesUtils.keywords.fetch() instead
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.37
People
(Reporter: philip.chee, Assigned: neil)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
From Bug 1100294 (Deprecate PlacesUtils.getURLAndPostDataForKeyword)
getURLAndPostDataForKeyword() is deprecated, please use PlacesUtils.keywords.fetch() instead
(In Bug 8583180 comment #0)
> getURIAndPostDataForKeyword should be deprecated in favor of
> PlacesUtils.keywords.fetch(), but first we must fix the consumers.
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Since promiseShortcutOrURI already returns a promise, all I had to do was to move the code that handled the return from fetch into its then method, which would then resolve to a promise for the value returned from the then method, thus also saving me from manually returning a resolved promise.
Of course returning a promise instead a then method also works; the then then resolves when and to whatever the returned promise resolves.
Attachment #8588166 -
Flags: review?(iann_bugzilla) → review+
(In reply to neil@parkwaycc.co.uk from comment #3)
> Of course returning a promise instead a then method also works; the then
> then resolves when and to whatever the returned promise resolves.
Having a method called "then" really confused me when trying to read the above!
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.37
You need to log in
before you can comment on or make changes to this bug.
Description
•