Closed
Bug 1148483
Opened 10 years ago
Closed 10 years ago
[Customizer] Icons not loaded within fxos-customizer element
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
The gaia-icons font is loaded in the light DOM and the CSS rules defined are not available within the fxos-customizer shadow DOM. As a result, none of the icons are rendered in the fxos-customizer element.
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Figured out the issue related to shadow DOM. However, we unfortunately also need to inline the icon font because @import fails in an add-on.
Attachment #8584663 -
Flags: review?(drs)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8584663 [details]
pull-request (master)
(In reply to Justin D'Arcangelo [:justindarc] from comment #1)
> Figured out the issue related to shadow DOM. However, we unfortunately also
> need to inline the icon font because @import fails in an add-on.
I think this is only failing because we can't import CSS in add-ons yet. We should comment this in code and mention bug 1148218.
Attachment #8584663 -
Flags: review?(drs) → review+
|
|
||
Updated•10 years ago
|
|
|
Assignee | |
Comment 3•10 years ago
|
||
Landed on master:
https://github.com/fxos/customizer/commit/d8330652c982d794b1938ca726d358998427a904
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Whiteboard: [lightsaber] → [ignite]
|
|
||
Updated•10 years ago
|
Whiteboard: [ignite] → [spark]
You need to log in
before you can comment on or make changes to this bug.
Description
•