Closed Bug 1148677 Opened 10 years ago Closed 10 years ago

"Send to other devices" icon blurry in long-press send link context menu

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

All
Android
defect
Not set
normal

Tracking

(firefox38 verified, firefox39 verified, firefox40 verified)

VERIFIED FIXED
Firefox 40
Tracking Status
firefox38 --- verified
firefox39 --- verified
firefox40 --- verified

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(7 files, 7 obsolete files)

(deleted), image/png
Details
(deleted), application/zip
Details
(deleted), image/png
antlam
: feedback+
Details
(deleted), image/png
Details
(deleted), image/png
Details
(deleted), image/png
Details
(deleted), text/x-review-board-request
liuche
: review+
Details
Attached image Screenshot (obsolete) (deleted) —
Long press a link, click share, and scroll to see send to other devices. Affects pre-Android L too.
Seems like I need to supply a specific icon asset. What're the dimensions?
Flags: needinfo?(michael.l.comella)
I think these are all application icon assets so they're huge - I'm not sure if this uses the 48dp x 48dp icon, or the 96dp x 96dp icon (I'd guess the former). Send by the assets and I'll try them out!
Flags: needinfo?(michael.l.comella) → needinfo?(alam)
Attached file appicon_shareplane.zip (obsolete) (deleted) —
Try these, I have one for 96px x 96px and another for 48px x 48px
Flags: needinfo?(alam) → needinfo?(michael.l.comella)
Can I get these assets in XHDPI form for testing (and I'll ping again for the full range of DPI for the size I actually need)?
Flags: needinfo?(michael.l.comella) → needinfo?(alam)
Attached image appicon_shareplane_XHDPI.png (obsolete) (deleted) —
Try this!
Flags: needinfo?(alam)
Attached image Screenshot post asset (obsolete) (deleted) —
I think that looks correct - can I get the full set of assets?
Attachment #8586515 - Flags: feedback?(alam)
Attached file appicon_shareplane.zip (obsolete) (deleted) —
Attached. Screenshot?
Attachment #8585633 - Attachment is obsolete: true
Flags: needinfo?(michael.l.comella)
Assignee: nobody → michael.l.comella
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(michael.l.comella)
Attached file appicon_shareplane2.zip (obsolete) (deleted) —
These are smaller - try them instead.
Attachment #8586532 - Attachment is obsolete: true
Attached image Screenshot (pre commit) (deleted) —
(In reply to Anthony Lam (:antlam) from comment #8) > These are smaller - try them instead. The icons get scaled - it's always been that big. We'd need to add padding to get it to look smaller.
Attachment #8584899 - Attachment is obsolete: true
Flags: needinfo?(michael.l.comella) → needinfo?(alam)
Attached file appicon2_shareplane.zip (deleted) —
Took a step back, discussed on IRC. These assets are 48dp square, same as the build icons. They should be sharp in all dialogs now. But, we'll have to see. Give these a try.
Attachment #8586854 - Attachment is obsolete: true
Flags: needinfo?(alam) → needinfo?(michael.l.comella)
Attached image Screenshot (post commit) (deleted) —
Nice! I think this looks better all around!
Attachment #8586499 - Attachment is obsolete: true
Attachment #8586515 - Attachment is obsolete: true
Attachment #8586515 - Flags: feedback?(alam)
Flags: needinfo?(michael.l.comella)
Attachment #8586928 - Flags: feedback?(alam)
Attached file MozReview Request: bz://1148677/mcomella (obsolete) (deleted) —
/r/6485 - Bug 1148677 - Use larger shareplane icon. r=liuche Pull down this commit: hg pull -r 6ac8cb91b80047821e78af3d005d8049e9b23dfd https://reviewboard-hg.mozilla.org/gecko/
Attachment #8586930 - Flags: review?(liuche)
Attachment #8586928 - Flags: feedback?(alam) → feedback+
Comment on attachment 8586930 [details] MozReview Request: bz://1148677/mcomella https://reviewboard.mozilla.org/r/6483/#review5427 ::: mobile/android/base/widget/ActivityChooserModel.java (Diff revision 1) > - resolveInfo.icon = R.drawable.share_plane; > + resolveInfo.icon = R.drawable.icon_shareplane; I'm confused - I see that drawable/share_plane has been modified, but I don't see it used anywhere with this change. Can we remove it entirely?
Attachment #8586930 - Flags: review?(liuche)
https://reviewboard.mozilla.org/r/6483/#review5491 > I'm confused - I see that drawable/share_plane has been modified, but I don't see it used anywhere with this change. Can we remove it entirely? It was deleted - `hg log --stat` also just shows modification (I had to look at `hg log -p`) so I wonder if this is just a shortcoming of hg (and reviewboard's particular access of it). I filed bug 1151121 for this.
Comment on attachment 8586930 [details] MozReview Request: bz://1148677/mcomella https://reviewboard.mozilla.org/r/6483/#review5497 Ship It!
Attachment #8586930 - Flags: review?(liuche) → review+
Comment on attachment 8586930 [details] MozReview Request: bz://1148677/mcomella This should land in 38 because bug 1122302 landed in 38. Approval Request Comment [Feature/regressing bug #]: bug 1122302 [User impact if declined]: Users who long-press share an item (link or image) will see a blurry "Send to other devices" icon. [Describe test coverage new/current, TreeHerder]: None [Risks and why]: Low - we replace some existing assets with new ones and then rename the asset (and then change the reference in code). In the worst case, we reference a different asset and the icon appears incorrectly. [String/UUID change made/needed]: None
Attachment #8586930 - Flags: approval-mozilla-beta?
Attachment #8586930 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Flags: qe-verify+
Comment on attachment 8586930 [details] MozReview Request: bz://1148677/mcomella Should be in 38 beta 4.
Attachment #8586930 - Flags: approval-mozilla-beta?
Attachment #8586930 - Flags: approval-mozilla-beta+
Attachment #8586930 - Flags: approval-mozilla-aurora?
Attachment #8586930 - Flags: approval-mozilla-aurora+
Attached image Screenshot_2015-04-08-16-39-38.png (deleted) —
Verified as fixed using: Device: Samsung S5 (Android 4.4) Build: Firefox for Android 40.0a1 (2015-03-07)
Attached image Screenshot (quick share) (deleted) —
I *think* I told you over irc that this didn't change, Anthony, and Teodora pointed out on irc that it did - just wanted to see what you think.
Attachment #8589641 - Flags: feedback?(alam)
Verified fixed on latest Aurora 39.0a2 and Beta 38.0b3 on Galaxy Note 3 with Android 4.4.2
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: