Seth Fowler [:seth] [:s2h] Assignee
	Description • 9 years ago

Bug 1120271 introduced compacting support for SourceBuffer in ImageLib. Unfortunately, the code assumes that if there is only one chunk in the SourceBuffer, it doesn't need to be compacted. In cases where we got a false value for Content-Length, though, that's not true. Bug 1145762 is an example of such a situation.

The fix: we should always compact, even if we only have one chunk.

	Seth Fowler [:seth] [:s2h] Assignee
	Comment 1 • 9 years ago

Here's the patch. I've verified that this fixes the issue in bug 1145762. (Even
without the GetContentLength fix in bug 1148682.)

	Seth Fowler [:seth] [:s2h] Assignee
	Comment 2 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fbc7048d9cc

	Seth Fowler [:seth] [:s2h] Assignee
	Comment 3 • 9 years ago

Comment on attachment 8584933 [details] [diff] [review]
Compact SourceBuffer even if it contains only one chunk.

Oops, just realized I didn't request review on this.

	Seth Fowler [:seth] [:s2h] Assignee
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/f64b5c0ee649

	Carsten Book [:Tomcat]
	Comment 5 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/f64b5c0ee649

	Seth Fowler [:seth] [:s2h] Assignee
	Comment 6 • 9 years ago

Comment on attachment 8584933 [details] [diff] [review]
Compact SourceBuffer even if it contains only one chunk.

Approval Request Comment
[Feature/regressing bug #]: Bug 1120271 introduced the bug. This fixes bug 1145762.
[User impact if declined]: Unnecessary memory consumption, resulting in OOM in some cases.
[Describe test coverage new/current, TreeHerder]: On m-c, and I believe now m-a.
[Risks and why]: Low risk.
[String/UUID change made/needed]: None.

	Sylvestre Ledru [:Sylvestre]
	Comment 7 • 9 years ago

Comment on attachment 8584933 [details] [diff] [review]
Compact SourceBuffer even if it contains only one chunk.

Regressions are unlikely, taking it.
should be in 38 beta 2

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 9 years ago

https://hg.mozilla.org/releases/mozilla-beta/rev/ca8eaf3366e5