There are several tests use expression closure in jstests and jit-test, and some of them are not testing expression closure itself, so it would be better to switch to one of function declaration, function expression, or arrow function. for example, js/src/tests/js1_8_5/extensions/reflect-parse.js uses a lot of expression closures, but most of them can be function declarations. > function program(elts) Pattern({ type: "Program", body: elts }) > function exprStmt(expr) Pattern({ type: "ExpressionStatement", expression: expr }) > function throwStmt(expr) Pattern({ type: "ThrowStatement", argument: expr }) > function returnStmt(expr) Pattern({ type: "ReturnStatement", argument: expr }) > ...

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=11e843688748

Thank you for reviewing :) can I ask reviewing one more patch?

Comment on attachment 8586038 [details] [diff] [review] Part 1: Remove some use of expression closure from jstests ecma_7/. Review of attachment 8586038 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! I've been meaning to do this, at least for the typed array stuff, to permit these tests to be shared with other engines.

Thank you! Landed without reflect-parse.js and shell.js in Part 2. I'll land it as Part 4 after rebasing on bug 1149769, since it should be easier than the reverse case. https://hg.mozilla.org/integration/mozilla-inbound/rev/45ecfb3e9f6f https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a98220bb3f https://hg.mozilla.org/integration/mozilla-inbound/rev/09bdf23bd4b2

https://hg.mozilla.org/mozilla-central/rev/45ecfb3e9f6f https://hg.mozilla.org/mozilla-central/rev/a9a98220bb3f https://hg.mozilla.org/mozilla-central/rev/09bdf23bd4b2

rebased on bug 1149769 https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8a12b1e3b0