Closed
Bug 114926
Opened 23 years ago
Closed 23 years ago
Build object with appropriate elements when checking links fails
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.8
People
(Reporter: cmanske, Assigned: akkzilla)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
In the link checking code (see bug 91388 for first implementation), we should
build a JS array of objects containing the element whose URL was checked
(usually an <img> or <a>), and the result of the URL checking (whether the
failure was "timeout" or the file wasn't found.)
This will be passed to the Link Check dialog that will show the user which links
were bad and allow them to edit the properties on the object owning the URL.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
Assignee | ||
Comment 1•23 years ago
|
||
Looking at nsIURIChecker, I realized it didn't make sense to add it to that
class. But in the JS, we have an nsIURIRefObject. Here's a patch to save those
in a parallel array. Does this (patch coming) seem like a reasonable solution?
Assignee | ||
Comment 2•23 years ago
|
||
Reporter | ||
Comment 3•23 years ago
|
||
Good start. I actually only need the object when the link fails to load, and I
need to know if the cause is a 'timeout' or failure to find the file at all.
Assignee | ||
Comment 4•23 years ago
|
||
We have to save all the ref objects, because we don't know at the time we're
saving them whether their links will turn out to be live or not. The link
checker object tells you whether it was a timeout or a bad link.
Assignee | ||
Comment 5•23 years ago
|
||
I believe this got checked in along with the new dialog.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•23 years ago
|
||
yes, it was checked in, so I'll verify this
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•