Bug 1138293 replaced a bunch of moz_free with free, and as a result, this triggered a warning in GCC that only happens under some particular circumstances (that particular one only happens on pgo linux64 builds, for instance). Cf. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54202 it appears this warning is not accurate and may have plenty of false positives. We were getting away with it because we weren't using free() that much. I propose that we disable this warning, on PGO builds only for now.

Making this a r=me for landing, but hoping cpeterson will regularize.

(In reply to Mike Hommey [:glandium] from comment #1) > Created attachment 8585920 [details] [diff] [review] > Don't make free-nonheap-object warning an error > > Making this a r=me for landing, but hoping cpeterson will regularize. To make things clearer, this needs landing to unbust linux64 pgo builds after bug 1138293.

Comment on attachment 8585920 [details] [diff] [review] Don't make free-nonheap-object warning an error Review of attachment 8585920 [details] [diff] [review]: ----------------------------------------------------------------- LGTM