Closed
Bug 1149626
Opened 10 years ago
Closed 10 years ago
Performance timeline legends should be dark with light text in dark theme in LineGraphs
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)
Tracking
(firefox40 verified, firefox41 fixed)
VERIFIED
FIXED
Firefox 41
People
(Reporter: jsantell, Assigned: vporof)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jsantell
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → jsantell
Reporter | ||
Updated•10 years ago
|
Blocks: perf-polish
Assignee | ||
Updated•10 years ago
|
Summary: Performance timeline legends should be dark with light text in dark theme → Performance timeline legends should be dark with light text in dark theme in LineGraphs
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Reporter | ||
Comment 2•10 years ago
|
||
These can be restyled in several ways, even something like the original memory mockup: https://bug960671.bugzilla.mozilla.org/attachment.cgi?id=8361231
They don't have to necessarily just be dark versions of what is there now.
Assignee: jsantell → nobody
Status: ASSIGNED → UNCONFIRMED
Ever confirmed: false
Assignee | ||
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
This was really annoying me.
Attachment #8607678 -
Flags: review?(jsantell)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8607678 [details] [diff] [review]
v1
Review of attachment 8607678 [details] [diff] [review]:
-----------------------------------------------------------------
This looks obscenely better. Thank you. In the future, I wonder if we can make these more minimal (just showing maybe 10-50fps rather than separate markers for each)
:shipit:
Attachment #8607678 -
Flags: review?(jsantell) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Updated•10 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Flags: qe-verify+
Comment 7•9 years ago
|
||
Comment on attachment 8607678 [details] [diff] [review]
v1
Approval Request Comment
[Feature/regressing bug #]: 1167252, the new performance tool
[User impact if declined]: Won't ship the performance tool
[Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift
[Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel.
[String/UUID change made/needed]: None
Attachment #8607678 -
Flags: approval-mozilla-aurora?
Comment 8•9 years ago
|
||
status-firefox40:
--- → fixed
Comment 9•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 10•9 years ago
|
||
Comment on attachment 8607678 [details] [diff] [review]
v1
Change approved to skip one train as part of the spring campaign.
Attachment #8607678 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•9 years ago
|
||
Verified fixed on Aurora 40.0a2 (2015-06-09), using Windows 7 (x64), Ubuntu 13.10 (x64) and Mac OS X 10.9.5.
The "max", "min" and "avg" legend tooltips are light text on dark background while the dark theme is enabled and dark text on light background while the light theme is enabled.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•