Jeff Walden [:Waldo] Reporter
	Description • 9 years ago

Particularly, using ValueToId and IsTypedArrayIndex is just not really right.  Without checking, I'd presume doing it this way means that if I were to do

   Atomics.load(arr, Symbol.iterator);

then I wouldn't get an error thrown trying to convert the index to a number.  But ordinarily trying to convert a symbol to anything is expected to throw.  This seems inconsistent with, e.g. new DataView(typedArray).getInt8(Symbol.iterator).

	Lars T Hansen [:lth]
	Comment 1 • 9 years ago

Seems plausible.  The spec is lagging here too, if I'm not mistaken.

	Lars T Hansen [:lth]
	Comment 2 • 9 years ago

GetSharedTypedArrayIndex is gone, but GetTypedArrayIndex has the same problem.

	Lars T Hansen [:lth]
	Comment 3 • 8 years ago

GetTypedArrayIndex now delegates to ToIntegerIndex, which appears to do the right thing, and if it should turn out that it does not the right thing at least we're doing things consistently.  A big Thank You to whoever cleaned this up.