Closed Bug 1149999 Opened 10 years ago Closed 10 years ago

Animation inspector doesn't re-conciliate transitions when played several times and doesn't allow to set currentTime/resume

Categories

(DevTools :: Inspector: Animations, defect)

defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

Details

Attachments

(2 files, 1 obsolete file)

When bug 1120833 will be implemented, the animation panel will refresh when animations are added or removed, so this bug is required. STR: - https://dl.dropboxusercontent.com/u/714210/transition.html - Open the animation inspector panel - Select the <div> in the inspector - Click on the <div> in the page => 2 transitions appear in the panel (width and height) - Click on the <div> again => 2 new transitions appear. This is somehow fine because they are different transitions. - Click again on the <div> => still 2 new transitions. This isn't correct, the panel should manage to see these are the same 2 transitions that were originally displayed and just show these ones as running again. Also, trying to seek one of the displayed transitions doesn't do anything.
Platform bug 1149990 is where the discussions about how to resume finished transitions will take place.
Depends on: 1120833, 1149990
When the transitions are added, we get a mutation event (thanks to bug 1123523) and with that a list of Animation objects. I just checked and realized that the Animation object is a new one every time. So if we want to re-conciliate with existing Animation objects, we're going to have to use a unique identifier. This could be a pair of DOM Node + transition property name. One problem with this though: when transitionProperty is "all". Maybe we could consider "all" transitions as just 1 animation in the inspector. This would require changes to the AnimationPlayerActor because it would not just represent one Animation but potentially several of them.
Blocks: 985861
Depends on: 1122414
Attached file MozReview Request: bz://1149999/pbrosset (obsolete) (deleted) —
/r/7113 - Bug 1149999 - 1 - Display transition names in animation-panel now that they have names /r/7115 - Bug 1149999 - 2 - Send animation removed events to the animation-panel for re-starting transitions Pull down these commits: hg pull -r 06fb4699438939efb42b363cbfabd0430a15d8c3 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8593227 - Flags: review?(past)
These 2 parts solve the problem described in the STR in comment 0. They don't solve yet the last problem where seeking a finished transition doesn't work. That depends on bug 1149990.
Attachment #8593227 - Flags: review?(past) → review+
Keywords: leave-open
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
My understanding so far is that when bug 1149990 lands, the problem whereby it's not possible to set the current time of finished transitions in the animation inspector will be solved automatically, so I don't need to leave this open after all, and no need to depend on bug 1149990. If this doesn't work after bug 1149990 lands, I'll file a new bug then.
No longer depends on: 1149990
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Attachment #8593227 - Attachment is obsolete: true
Attachment #8619940 - Flags: review+
Attachment #8619941 - Flags: review+
Depends on: 1155927
Component: Developer Tools: Inspector → Developer Tools: Animation Inspector
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: