To make it easier for partners to reuse parts of our code in proprietary plugins, gmp-clearkey should only contain and use/#include Apache 2 licensed code.

Relicense MPL to Apache 2 in gmp-clearkey, and remove dependency on MFBT. Will take the first review I get... https://treeherder.mozilla.org/#/jobs?repo=try&revision=72ce6f4fee6f

Comment on attachment 8587317 [details] [diff] [review] Patch Review of attachment 8587317 [details] [diff] [review]: ----------------------------------------------------------------- Define NDEBUG for release builds

We should fix this soon, but we don't need to uplift the license change.

(In reply to Edwin Flores [:eflores] [:edwin] from comment #5) > Comment on attachment 8587317 [details] [diff] [review] > Patch > > Review of attachment 8587317 [details] [diff] [review]: > ----------------------------------------------------------------- > > Define NDEBUG for release builds I tested, and we do define NDEBUG in --disable-debug builds and don't in --enable-debug. So we're good as is.

Comment on attachment 8587317 [details] [diff] [review] Patch Review of attachment 8587317 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/gmp-clearkey/0.1/RefCounted.h @@ +57,5 @@ > + T* operator->() const { return mPtr; } > + > +private: > + void Assign(T* aPtr) { > + if (mPtr) { There's a foot-gun here. If we assign a RefPtr to itself, we'll we'll deref mPtr before we addref it, so we'll end up destroying the thing pointed to if that's the last ref.

Comment on attachment 8587317 [details] [diff] [review] Patch Review of attachment 8587317 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/gmp-clearkey/0.1/RefCounted.h @@ +57,5 @@ > + T* operator->() const { return mPtr; } > + > +private: > + void Assign(T* aPtr) { > + if (mPtr) { I noticed and concluded it was safe because Assign() is private and there is no assign operator and RefPtr is not convertible to T*. What call path could result in self-assignment?