Closed
Bug 1150946
Opened 10 years ago
Closed 10 years ago
Relabel Service Workers toolbox option
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: jryans, Assigned: jaoo)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Bug 1003991 added a new toolbox option:
"Enable Service Workers testing features"
From the bug, it allows you to use them over http instead of requiring https, but that is not all clear from the name.
At the very least, we should document the meaning, but should we re-label the option too?
Reporter | ||
Comment 1•10 years ago
|
||
José, are the plans to put other Service Worker developer features behind the same flag, or will it remain as just allowing them over HTTP?
Depends on: 1003991
Flags: needinfo?(josea.olivera)
Assignee | ||
Comment 2•10 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] from comment #1)
> José, are the plans to put other Service Worker developer features behind
> the same flag, or will it remain as just allowing them over HTTP?
No, there aren't AFAIK. We should re-label the option. Do you want me to do it? I could add some doc if you want to make things clearer. Sorry. Thanks!
Flags: needinfo?(josea.olivera) → needinfo?(jryans)
Reporter | ||
Comment 3•10 years ago
|
||
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> (In reply to J. Ryan Stinnett [:jryans] from comment #1)
> > José, are the plans to put other Service Worker developer features behind
> > the same flag, or will it remain as just allowing them over HTTP?
>
> No, there aren't AFAIK. We should re-label the option. Do you want me to do
> it? I could add some doc if you want to make things clearer. Sorry. Thanks!
It would be great to re-label it something like "Enable Service Workers over HTTP (when toolbox is open)". Also, updating the options docs[1] would be great, but we can also set "dev-doc-needed" here to have them updated by MDN Docs team.
If you're able to make the label change, that would be great!
[1]: https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox#Settings
Flags: needinfo?(jryans)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jaoo
Assignee | ||
Comment 4•10 years ago
|
||
This patch changes the label to "Enable Service Workers over HTTP (when toolbox is open)". Once it lands I'll add some doc in MDN.
Nikhil, are you also ok with this change?
Flags: needinfo?(nsm.nikhil)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Attachment #8589116 -
Flags: review+
Flags: needinfo?(nsm.nikhil)
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8589116 [details] [diff] [review]
v1
:jryans, could you have a look as well please? Thanks!
Attachment #8589116 -
Flags: review?(jryans)
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8589116 [details] [diff] [review]
v1
Review of attachment 8589116 [details] [diff] [review]:
-----------------------------------------------------------------
Text changes look great to me, but you'll need to change the string IDs so the l10n team can pick it up[1], and then update the files where they are referenced.
Maybe replace "enableServiceWorkersTesting" with "enableServiceWorkersHTTP"? Up to you, as long they change! :)
[1]: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings
Attachment #8589116 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Addressees review comments made at comment 6.
Carrying out r=nsm,jryans
Try results at https://treeherder.mozilla.org/#/jobs?repo=try&revision=f583a4dc70bc
Attachment #8589116 -
Attachment is obsolete: true
Assignee | ||
Comment 8•10 years ago
|
||
Try looks good, lets land this then. Thanks!
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 10•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 11•10 years ago
|
||
Doc added at https://developer.mozilla.org/en-US/docs/Tools/Tools_Toolbox. Thanks!
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•