Closed Bug 1151052 Opened 10 years ago Closed 9 years ago

[RTL] [SMS] send icon in compose is flipped

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

x86
macOS
defect

Tracking

(b2g-v2.2 affected, b2g-master affected)

RESOLVED INVALID
Tracking Status
b2g-v2.2 --- affected
b2g-master --- affected

People

(Reporter: tif, Unassigned)

References

Details

(Whiteboard: [sms-most-wanted], [2.2-nexus-5-l])

Attachments

(3 files)

Attached file sms.pdf (deleted) —
STR: 1. Change language to Arabic 2. Go to SMS and tap new message 3. Observe the send icon (paper plane) Actual The icon is mirrored from LTR languages Expected The icon keep its LTR orientation
Blocks: messages-rtl
blocking-b2g: --- → 2.2?
Priority: -- → P2
blocking-b2g: 2.2? → 2.2+
We made this on purpose (in bug 1053708) because this is in our opinion more logical to RTL users. I'd like to add that the send button is quite a beast (see attachment 8501738 [details] for the various cases including DSDS) and so it would be risky to revert this now. Who can decide here?
Flags: needinfo?(swilkes)
Flags: needinfo?(nefzaoui)
Flags: needinfo?(lebedel.delphine)
Thanks Julien. It's not worth the additional risk at this point. I think it makes at least as much sense pointing to the left as it is now. Unblocking for 2.2 -- I'll leave the ni? for Stephany to review & comment if this is something we'd need to tackle in the future.
blocking-b2g: 2.2+ → ---
Flags: needinfo?(nefzaoui)
Flags: needinfo?(lebedel.delphine)
Lancy: please follow this bug and make sure test case reflects final decision. Thanks!
Flags: needinfo?(yulan.zhu)
Delphine, OK, the related test case has been updated. Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15374/
Flags: needinfo?(yulan.zhu) → in-moztrap+
This issue still exist on the latest Flame 2.2 and Flame 3.0 build. Reproducing rate:10/10 Flame 2.2 build: Build ID 20150407162504 Gaia Revision ea735c21bfb0d78333213ff0376fce1eac89ead6 Gaia Date 2015-04-07 20:58:15 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3f86ddb7f719 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150407.195227 Firmware Date Tue Apr 7 19:52:39 EDT 2015 Bootloader L1TC000118D0 Flame 3.0 build: Build ID 20150407160201 Gaia Revision 84cbd4391fb7175d5380fa72c04d68873ce77e6d Gaia Date 2015-04-07 17:33:14 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/078128c2600a Gecko Version 40.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150407.193600 Firmware Date Tue Apr 7 19:36:12 EDT 2015 Bootloader L1TC000118D0
Whiteboard: MGSEI-RTL-3F
From what I understand, the "send" button is like an arrow to "outside" and that's why the current "flip" makes more sense in my opinion. Maybe SMS designers Fang and Jenny could also comment on the UX/Design side.
Flags: needinfo?(jelee)
Flags: needinfo?(fshih)
The spec is very clear about this and why, and this doesn't follow the spec (which was done in concert with members of the Mozilla Arabic community who are native speakers). Removing UX flags since we covered this thoroughly in the UX spec.
Flags: needinfo?(swilkes)
Flags: needinfo?(jelee)
Flags: needinfo?(fshih)
Stephany, let me disagree. The spec says: DO NOT MIRROR - Most Icons (except those that indicate direction, such as arrows) Well, this is IMO an arrow. That's why I wanted to ask Fang, to know if this is really thought as an arrow, or if it just happens to look like an arrow.
Flags: needinfo?(swilkes)
Flags: needinfo?(fshih)
Hi Julien, Thanks for the double confirmed. It's actually an icon that happens to look like an arrow. The original concept is to use paper airplane to symbolize the sent icon. Thanks!
Flags: needinfo?(swilkes)
Flags: needinfo?(fshih)
OK thanks Fang. We'll do the change then.
Whiteboard: MGSEI-RTL-3F → MGSEI-RTL-3F [sms-most-wanted]
Lancy: please don't update test cases until final decision is taken in a bug... that's just extra work for nothing ;) Now that decision is taken (see comment 10) you can update the test case accordingly. thanks
Flags: needinfo?(yulan.zhu)
Delphine, OK, I have updated the related test case according to the final decision.
Flags: needinfo?(yulan.zhu)
QA Whiteboard: [MGSEI-Triage+]
Hey Elie - Fang's comment 9 is saying that the icon should be the SAME in both RTL and LTR languages (i.e. not flipped). As your screenshot shows, it's still flipping in RTL languages and thus still reproducible. Thanks!
Flags: needinfo?(zikui.yang)
(In reply to Tiffanie Shakespeare from comment #14) > Hey Elie - Fang's comment 9 is saying that the icon should be the SAME in > both RTL and LTR languages (i.e. not flipped). > > As your screenshot shows, it's still flipping in RTL languages and thus > still reproducible. Thanks! Hey Tiffanie, Thanks for your soft reminder. Yes, this issue can be reproduced. We had opened one same bug 1139732, but that bug had been marked as INVALID, that makes me confused. Hi Julien, This issue can be reproduced on latest build of Flame 2.2/3.0 and Nexus5 2.2/3.0 by STRs in comment 0. Could you tell us how is this bug going at your side? Device information: Flame 2.2 Build ID: 20150527002504 Flame 3.0 Build ID: 20150527160204 Nexus5 2.2 Build ID: 20150527002504 Nexus5 3.0 Build ID: 20150527160204
Flags: needinfo?(zikui.yang) → needinfo?(felash)
Whiteboard: MGSEI-RTL-3F [sms-most-wanted] → MGSEI-RTL-3F [sms-most-wanted], [2.2-nexus-5-l]
The bug is not priorized so unless you tell me this confuses a lot of people speaking a RTL-language this won't be worked on soon as we have higher priority tasks to do currently.
Flags: needinfo?(felash)
This does not follow the UX specs for 2.2 (see comment 9 and comment 10) BUT as per comment 2, Dylan decided not to bock 2.2 on this. So I'm not going to try and prioritize this bug more given we're so late in the cycle. thanks
blocking-b2g: --- → 2.2?
(taking out nom' - not intended)
blocking-b2g: 2.2? → ---
QA Whiteboard: [MGSEI-Triage+] → [MGSEI-Triage+]MGSEI-RTL-3F
Whiteboard: MGSEI-RTL-3F [sms-most-wanted], [2.2-nexus-5-l] → [sms-most-wanted], [2.2-nexus-5-l]
This issue can be reproduced on latest build of AriesKK_V2.5. Rate:5/5 Build ID 20150814002719 Gaia Revision 39b121515ab8a8c3ea07f26d3ba1dd792e90217c Gaia Date 2015-08-13 18:25:42 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/4e883591bb5dff021c108d3e30198a99547eed1e Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150813.235024 Firmware Date Thu Aug 13 23:50:32 UTC 2015 Bootloader s1
Blocks: 1181936
Attached image AriesKK_V2.5.png (deleted) —
I'd like to know how this was done on 2.0m branch before moving forward. I've been told it's been implemented like it is now on master and so I'd favor keeping it like it is.
Kaze, can you confirm the orientation of this icon on 2.0m?
Flags: needinfo?(fabien)
Dylan, Julien, I confirm that the send icon is MIRRORED on our 2.0m (I don't know about what is on mozilla's v2.0m). That's how we decided to implement it with Kaze and Ahmed. I'm also personally in favor of mirroring the send icons, because if we don't mirror it, we should not mirror the outgoing and incoming bubble either imho. NI Ahmed to be sure.
Flags: needinfo?(kaze) → needinfo?(nefzaoui)
Indeed the send icon was mirrored in 2.0m RTL that was signed off for Orange back then. I'm in favour of mirroring this icon (it's more of a right/wrong rather than IMO vs other opinions) (Stephany's comment might be related to the fact that in 2.2 back icons, apps order and many other things were not mirrored..) But as of now we have a spec for 2.5 that makes sure such conflicts don't happen.
Flags: needinfo?(nefzaoui)
Thanks guys, let's close this bug, at last.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: