Closed
Bug 115153
Opened 23 years ago
Closed 22 years ago
'PRIntn' should never be used in the fields of a structure
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.4alpha
People
(Reporter: sfraser_bugs, Assigned: dbaron)
Details
(Keywords: memory-footprint, Whiteboard: [patch])
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
nsSpaceManager uses PRIntn for its 'mNumFrames' member. This is bad, because
PRIntn can range between 16 and 64 bits big depending on the processor. The NSPR
headers explicitly state this:
/************************************************************************
** TYPES: PRUintn
** PRIntn
** DESCRIPTION:
** The PRIntn types are most appropriate for automatic variables. They are
** guaranteed to be at least 16 bits, though various architectures may
** define them to be wider (e.g., 32 or even 64 bits). These types are
** never valid for fields of a structure.
************************************************************************/
|
||
Comment 3•22 years ago
|
||
.
Assignee: other → misc
Component: Layout → Layout: Misc Code
QA Contact: ian → nobody
|
Assignee | |
Comment 4•22 years ago
|
||
|
|
Assignee | |
Comment 5•22 years ago
|
||
Taking.
Assignee: misc → dbaron
Whiteboard: [patch]
Target Milestone: mozilla1.1alpha → mozilla1.4alpha
|
|
Assignee | |
Updated•22 years ago
|
Attachment #115445 -
Flags: superreview?(sfraser)
|
||
Updated•22 years ago
|
Attachment #115445 -
Flags: superreview?(sfraser)
Attachment #115445 -
Flags: superreview+
Attachment #115445 -
Flags: review+
|
|
Assignee | |
Comment 6•22 years ago
|
||
Fix checked in to trunk, 2003-03-11 15:56 PST.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•