Closed
Bug 1151646
Opened 10 years ago
Closed 10 years ago
indexedDB::::CancelableRunnableWrapper::Cancel releases CCed objects after worker CC is shut down
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mccr8, Assigned: bent.mozilla)
References
Details
Attachments
(2 files)
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
I came across a few of these. It looks like there was an IDB runnable that is releasing a DETH, but it is late enough in shutdown that the CC is gone.
https://crash-stats.mozilla.com/report/index/d7968201-b10e-4c9d-a1a1-567cd2150401#allthreads
https://crash-stats.mozilla.com/report/index/65738f58-194c-4bf6-9b9b-f19ac2150401
https://crash-stats.mozilla.com/report/index/5192ba6f-1389-4daf-97a0-8fabe2150401
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
I think this is all we need to do.
Attachment #8588814 -
Flags: review?(khuey)
Assignee | ||
Comment 2•10 years ago
|
||
This isn't stcitly needed for this bug but while I was looking here I noticed that the runtime-private stuff has grown a few too many warts over the years. This cleans it up a little. No changes to behavior.
And the IDBFactory change was a silly assertion failure fix.
Attachment #8588816 -
Flags: review?(khuey)
Attachment #8588814 -
Flags: review?(khuey) → review+
Attachment #8588816 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/736c8f8f8c9b
https://hg.mozilla.org/mozilla-central/rev/d225c07cf671
https://hg.mozilla.org/mozilla-central/rev/40cbdbbf2a26
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•