Closed Bug 1152242 Opened 10 years ago Closed 10 years ago

Also need to enable e10s in mozinfo if nested_oop is enabled

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(e10s+, firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
e10s + ---
firefox40 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Enable e10s in mozinfo (obsolete) (deleted) — Splinter Review
nested_oop option implies that e10s has to be enabled. SO, we have to also set e10s to true in mozinfo if nested_oop option is presented.
Attachment #8589544 - Flags: review?(ted)
Ted, could you please take a look at the patch? Actually, I should have done this in bug 1038620 but I missed that. Thanks.
Assignee: nobody → kechang
Comment on attachment 8589544 [details] [diff] [review] Enable e10s in mozinfo Review of attachment 8589544 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/mochitest/mochitest_options.py @@ +624,5 @@ > > if options.nested_oop: > if not options.e10s: > options.e10s = True > + mozinfo.update({"e10s": options.e10s}) I'd just move the mozinfo.update line from the top of the function to after this if block so we're not repeating ourselves. It's not a really big deal either way though.
Attachment #8589544 - Flags: review?(ted) → review+
Thanks for reviewing this. I've moved mozinfo.update to the location as you suggested.
Attachment #8589544 - Attachment is obsolete: true
Attachment #8590038 - Flags: review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: