Closed
Bug 1152242
Opened 10 years ago
Closed 10 years ago
Also need to enable e10s in mozinfo if nested_oop is enabled
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(e10s+, firefox40 fixed)
RESOLVED
FIXED
mozilla40
People
(Reporter: kershaw, Assigned: kershaw)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
kershaw
:
review+
|
Details | Diff | Splinter Review |
nested_oop option implies that e10s has to be enabled.
SO, we have to also set e10s to true in mozinfo if nested_oop option is presented.
Assignee | ||
Updated•10 years ago
|
Attachment #8589544 -
Flags: review?(ted)
Assignee | ||
Comment 1•10 years ago
|
||
Ted, could you please take a look at the patch?
Actually, I should have done this in bug 1038620 but I missed that.
Thanks.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → kechang
Comment 2•10 years ago
|
||
Comment on attachment 8589544 [details] [diff] [review]
Enable e10s in mozinfo
Review of attachment 8589544 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/mochitest/mochitest_options.py
@@ +624,5 @@
>
> if options.nested_oop:
> if not options.e10s:
> options.e10s = True
> + mozinfo.update({"e10s": options.e10s})
I'd just move the mozinfo.update line from the top of the function to after this if block so we're not repeating ourselves. It's not a really big deal either way though.
Attachment #8589544 -
Flags: review?(ted) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks for reviewing this.
I've moved mozinfo.update to the location as you suggested.
Attachment #8589544 -
Attachment is obsolete: true
Attachment #8590038 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Blocks: e10s-harness
tracking-e10s:
--- → +
Comment 4•10 years ago
|
||
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•