Gert Van Waelvelde Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150407004006

Steps to reproduce:

1) Go to http://spotthestation.nasa.gov/sightings/
2) On the right of the page beneath "Location Lookup", choose a country from the "Select Country" list (e.g. "Belgium")


Actual results:

The "Select Country" list continues to show "Select Country" instead of the selected country, although it seems to be selected as the "State or Region" and/or "City" list update accordingly.

However, because the selected country isn't shown in the "Select Country" list, the 
"State or Region" and "City" lists start to behave funny, because the javascript on the page cannot keep track of what values are selected.


Expected results:

The selected country should be visibly selected in the list.
The javascript on the page should work normally.

	Loic
	Comment 1 • 9 years ago

Maybe a dupe of bug 1069355

	Gert Van Waelvelde Reporter
	Comment 2 • 9 years ago

(In reply to Loic from comment #1)
> Maybe a dupe of bug 1069355
I think this issue is different. It shows no selected value rather than the wrong one.
In bug 1069355 the next value in the list is selected, whereas here it selects the value correctly but doesn't show that in the list. It looks as if no value is selected, but the correct value is selected.
That's not the same as selecting a wrong value and showing that wrong value as selected.

	Alice0775 White
	Comment 3 • 9 years ago

Error in Browser Console:
TypeError: this.global is null SelectContentHelper.jsm:35:4

	Gert Van Waelvelde Reporter
	Comment 4 • 9 years ago

(In reply to Alice0775 White from comment #3)
> Error in Browser Console:
> TypeError: this.global is null SelectContentHelper.jsm:35:4

I get the same error. Should have noticed that before...

	Elbart
	Comment 5 • 9 years ago

Last good revision: 8af276ab8636 (2015-03-31)
First bad revision: 37ddc5e2eb72 (2015-04-01)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8af276ab8636&tochange=37ddc5e2eb72

Last good revision: e7e532d69293
First bad revision: fbd6031f2958
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e7e532d69293&tochange=fbd6031f2958

Maybe
f448a7140747	Neil Deakin — Bug 1117586, [e10s] select dropdowns cannot be opened with the keyboard, r=roc

	Elbart
	Comment 6 • 9 years ago

(In reply to Alice0775 White from comment #3)
> Error in Browser Console:
> TypeError: this.global is null SelectContentHelper.jsm:35:4

That error is also shown in builds before the regression.

	Alice0775 White
	Comment 7 • 9 years ago

pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=e7e532d69293&tochange=6df235c83a4a

Suspect: f448a7140747	Neil Deakin — Bug 1117586, [e10s] select dropdowns cannot be opened with the keyboard, r=roc

	Alice0775 White
	Comment 8 • 9 years ago

(In reply to Elbart from comment #6)
> (In reply to Alice0775 White from comment #3)
> > Error in Browser Console:
> > TypeError: this.global is null SelectContentHelper.jsm:35:4
> 
> That error is also shown in builds before the regression.

indeed, this is a different bug.

	Neil Deakin Assignee
	Comment 9 • 9 years ago

Bah, there should be a return in there.

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 10 • 9 years ago

Comment on attachment 8589691 [details] [diff] [review]
Fix missing return

Review of attachment 8589691 [details] [diff] [review]:
-----------------------------------------------------------------

Could use a test...

	Neil Deakin Assignee
	Comment 11 • 9 years ago

I'll add a test as part of bug 1047713.

	George Wright (:gw280) (needinfo me!)
	Comment 12 • 9 years ago

Neil, are we able to land this now? Can we land the test as part of this bug instead of as part of bug 1047713 as the latter is m8 and this is m6?

	Neil Deakin Assignee
	Comment 13 • 9 years ago

Yes, this can be checked in as is. I can check in a test next week.

	Carsten Book [:Tomcat]
	Comment 14 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/6988859d17c7

	Carsten Book [:Tomcat]
	Comment 15 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/6988859d17c7

	Marco Mucci [:MarcoM]
	Comment 16 • 9 years ago

Hi Neil, can you provide a point value.

	[SV Manager] Florin Mezei, QA (:FlorinMezei)
	Comment 17 • 9 years ago

Reproduced the issue in Firefox 40 Nightly from April 5th on Windows 7 x64. The issue no longer reproduces with latest Firefox 40 Nightly (BuildID=20150421092928) on Windows 7 x64 or Mac OS X 10.8.5. Selection works fine when using mouse or keyboard.