Closed
Bug 1152477
Opened 10 years ago
Closed 10 years ago
Update Theme Editor Home Screen Icon
Categories
(Firefox OS Graveyard :: Gaia::Theme Editor, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: drs)
References
Details
(Whiteboard: [spark])
Attachments
(2 files, 1 obsolete file)
Attached is the updated theme editor homescreen icon.
Reporter | ||
Comment 1•10 years ago
|
||
Hey guys, can whoever has a spare moment help update the icon? Thanks!
Flags: needinfo?(kgrandon)
Flags: needinfo?(etienne)
Flags: needinfo?(drs)
Assignee | ||
Comment 2•10 years ago
|
||
Whoever reviews this first, please go ahead and merge.
Assignee: nobody → drs
Status: NEW → ASSIGNED
Flags: needinfo?(drs)
Attachment #8589838 -
Flags: review?(kgrandon)
Attachment #8589838 -
Flags: review?(etienne)
Assignee | ||
Comment 3•10 years ago
|
||
Eric, I don't think a 512x512 icon is really necessary. Could you provide one at 256x256, instead? This is closer to the dimensions that we'll expect on the Aries device.
Flags: needinfo?(epang)
Updated•10 years ago
|
Flags: needinfo?(etienne)
Attachment #8589838 -
Flags: review?(kgrandon)
Attachment #8589838 -
Flags: review?(etienne)
Attachment #8589838 -
Flags: review+
Comment 4•10 years ago
|
||
Hope I didn't merged too eagerly :)
https://github.com/fxos/studio/pull/4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•10 years ago
|
||
Thanks, it's ok. I'll just merge another change without review when we get the 256x256 icon.
Flags: needinfo?(kgrandon)
Assignee | ||
Updated•10 years ago
|
Priority: -- → P1
Reporter | ||
Comment 6•10 years ago
|
||
Updated set of icons including the 256x256px
Attachment #8589830 -
Attachment is obsolete: true
Flags: needinfo?(epang) → needinfo?(drs)
Assignee | ||
Comment 7•10 years ago
|
||
Landed the 256x256 icon: https://github.com/fxos/studio/commit/211857741420018c6610e969bdf938dfeaef65d6
Flags: needinfo?(drs)
Updated•10 years ago
|
Whiteboard: [lightsaber] → [ignite]
Updated•10 years ago
|
Whiteboard: [ignite] → [spark]
Updated•10 years ago
|
Component: Gaia → Gaia::Theme Editor
Comment 8•10 years ago
|
||
You created a remote branch 1152477-icons in the "fxos/studio" repository, I don't have the right to delete it but likely you have.
Flags: needinfo?(drs)
You need to log in
before you can comment on or make changes to this bug.
Description
•