Closed
Bug 1152881
Opened 10 years ago
Closed 9 years ago
[marker] Add timeline markers to trace requestAnimationFrame callbacks
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: fitzgen, Unassigned)
References
Details
Really good to trace these and when they are taking too long. Right now you just get a lone "Function Call" with no idea why we entered JS.
Comment 1•10 years ago
|
||
I think this is just a particular instance of bug 1050500.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 2•10 years ago
|
||
No, I think this is good to have as a separate bug because it lets us know *why* we entered JS, while bug 1050500 only tells us *which* JS function we entered.
It could be useful to differentiate from setTimeout or DOM events, for example.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•10 years ago
|
Summary: Add timeline markers to trace requestAnimationFrame callbacks → [marker] Add timeline markers to trace requestAnimationFrame callbacks
Comment 3•10 years ago
|
||
(In reply to On vacation until May 17th from comment #2)
> No, I think this is good to have as a separate bug because it lets us know
> *why* we entered JS, while bug 1050500 only tells us *which* JS function we
> entered.
>
> It could be useful to differentiate from setTimeout or DOM events, for
> example.
I didn't want to close this again without your say-so, but please take a look
at the results from the first part of bug 1050500.
Screenshot: https://bug1050500.bugzilla.mozilla.org/attachment.cgi?id=8594882
Patch: https://bugzilla.mozilla.org/attachment.cgi?id=8594763&action=diff
It seems to me that the entry reason provided there is exactly what this bug
is about.
Comment 4•10 years ago
|
||
We do currently have Function Call markers with "FrameRequestCallback" causes from rAF, FWIW. So I do think this is already completed
Comment 5•9 years ago
|
||
What do we not have currently in our rAF markers that this bug is referring to?
Flags: needinfo?(nfitzgerald)
Reporter | ||
Comment 6•9 years ago
|
||
I think we can close this bug, there's been a bunch of changes and what I wanted is generally available now.
Flags: needinfo?(nfitzgerald)
Reporter | ||
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → WORKSFORME
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•