Per bug 1152522 comment 3, trun on logging for debug in test_tcp_control_channel.js

turn on log in mochitest and test_tcp_control_channel.js

add one more log

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=37b3f367724c

Comment on attachment 8590731 [details] [diff] [review] turn-on-log Review of attachment 8590731 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/presentation/provider/TCPPresentationServer.js @@ +13,2 @@ > function log(aMsg) { > dump("-*- TCPPresentationServer.js: " + aMsg + "\n"); that should be DEBUG && dump(...); so that it applies to all calls to log() no? @@ +57,5 @@ > let serverSocketPort = (aPort !== 0) ? aPort : -1; > > this._serverSocket = Cc["@mozilla.org/network/server-socket;1"] > .createInstance(Ci.nsIServerSocket); > + nit: trailing whitespace @@ +59,5 @@ > this._serverSocket = Cc["@mozilla.org/network/server-socket;1"] > .createInstance(Ci.nsIServerSocket); > + > + if(!this._serverSocket) { > + DEBUG && log("TCPPresentationServer - create server socket fail."); and then you would not need the DEBUG here ::: modules/libpref/init/all.js @@ +4534,5 @@ > pref("dom.beforeAfterKeyboardEvent.enabled", false); > > // Presentation API > pref("dom.presentation.enabled", false); > +pref("dom.presentation.tcpServer.debug", false); We usually name prefs with snake_case, note camelCase. So that I would rather like `dom.presentation.tcp_server.debug`

(In reply to Fabrice Desré [:fabrice] from comment #5) > Comment on attachment 8590731 [details] [diff] [review] > turn-on-log > > Review of attachment 8590731 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: dom/presentation/provider/TCPPresentationServer.js > @@ +13,2 @@ > > function log(aMsg) { > > dump("-*- TCPPresentationServer.js: " + aMsg + "\n"); > > that should be DEBUG && dump(...); so that it applies to all calls to log() > no? > > @@ +59,5 @@ > > this._serverSocket = Cc["@mozilla.org/network/server-socket;1"] > > .createInstance(Ci.nsIServerSocket); > > + > > + if(!this._serverSocket) { > > + DEBUG && log("TCPPresentationServer - create server socket fail."); > > and then you would not need the DEBUG here > If we change the position of |DEBUG|, |log| will evaluate its parameter and be time-consuming since lots of |JSON.stringify| like here: https://dxr.mozilla.org/mozilla-central/source/dom/presentation/provider/TCPPresentationServer.js#182 Is that OK?

Right, you just added a missing one. Let's only change the pref name then!

Modify by review comments https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e59178340f2

Comment on attachment 8592606 [details] [diff] [review] turn-on-log Review of attachment 8592606 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/presentation/provider/TCPPresentationServer.js @@ +58,5 @@ > > this._serverSocket = Cc["@mozilla.org/network/server-socket;1"] > .createInstance(Ci.nsIServerSocket); > + > + if(!this._serverSocket) { nit: if (...)

Modify nit, carry r+ Thanks Fabrice!