Closed
Bug 1153130
Opened 10 years ago
Closed 10 years ago
Firefox crashes when pointer events are enabled
Categories
(Firefox :: Untriaged, defect)
Tracking
()
RESOLVED
FIXED
Firefox 40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: alessarik, Assigned: alessarik)
References
Details
Attachments
(3 files, 1 obsolete file)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150320202338
Steps to reproduce:
Example is attached.
Pointer events should be enabled.
Press mouse button on "logs element" and quickly move to any direction.
Actual results:
FireFox will be crashed.
Expected results:
FireFox should be live!
|
Assignee | |
Comment 1•10 years ago
|
||
Some investigation:
Call stack:
nsINode::GetParentNode()
nsContentUtils::ContentIsDescendantOf()
PresShell::HandleEvent()
Issue place:
pointerEvent->retargetedByPointerCapture =
frame && frame->GetContent() &&
!nsContentUtils::ContentIsDescendantOf(frame->GetContent(), pointerCapturingContent);
Looks like frame became wrong in this place.
Possibly it happened at:
while(CheckPointerCaptureState(pointerEvent->pointerId));
|
|
Assignee | |
Comment 2•10 years ago
|
||
+ Added frame check to prevent crashes.
Attachment #8591654 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Updated•10 years ago
|
Attachment #8591654 -
Flags: review?(bugs) → review+
|
|
||
Updated•10 years ago
|
Summary: FireFox crashes when pointer events are enabled → Firefox crashes when pointer events are enabled
|
|
Assignee | |
Comment 4•10 years ago
|
||
+ Added test into mochitest system.
Attachment #8593444 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Test without patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebcd946cf0d0
Test with patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e701cfd580b
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8593444 [details] [diff] [review]
firefox_crashes_test_ver1.diff
rs+, assuming this test crashes without the patch, and doesn't with the patch.
s/FireFox/Firefox/
You could be consistent with { usage.
like, always function foobar() { and not
function barfoo()
{
Attachment #8593444 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 7•10 years ago
|
||
+ Only style changes
Attachment #8593444 -
Attachment is obsolete: true
Attachment #8593861 -
Flags: review?(bugs)
|
|
||
Updated•10 years ago
|
Attachment #8593861 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
If everybody have no objections, I put chekin-needed flag.
Keywords: checkin-needed
|
||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fded9ab07ba2
https://hg.mozilla.org/mozilla-central/rev/830adc7b7fb3
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
You need to log in
before you can comment on or make changes to this bug.
Description
•