Closed
Bug 1153151
Opened 10 years ago
Closed 8 years ago
make libcube sndio use non-blocking i/o
Categories
(Core :: Audio/Video: cubeb, defect, P4)
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: alex, Assigned: alex, Mentored)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
The current code is designed to use non-blocking writes to the device, but it actually uses blocking writes by mistake.
The fix switches it to non-blocking i/o, making sio_write() return immediately. In turn the device mutex is held for a very short period (as intended) which likely makes other threads wait less for the mutex to be released.
Tested on OpenBSD/amd64.
|
Assignee | |
Updated•10 years ago
|
Mentor: landry, kinetik
|
||
Updated•9 years ago
|
Component: Audio/Video → Audio/Video: MSG/cubeb/GMP
|
|
||
Updated•9 years ago
|
Component: Audio/Video: MediaStreamGraph → Audio/Video: cubeb
|
||
Updated•9 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
|
||
Comment 1•9 years ago
|
||
Alex, is this patch still valid ? If so i can do the hg plumbing to get it commited..
Flags: needinfo?(alex)
|
|
Assignee | |
Comment 2•9 years ago
|
||
it's still valid (1153179 should go in first, though).
Flags: needinfo?(alex)
Assignee: nobody → alex
Blocks: 1251502
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•