Closed
Bug 1153192
Opened 10 years ago
Closed 10 years ago
Cannot pass extra arguments to l10n-repack.py
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox38 fixed, firefox39 fixed, firefox40 fixed)
RESOLVED
FIXED
mozilla40
People
(Reporter: Fallen, Assigned: Fallen)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
gps
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
When including l10n.mk it is not possible to pass extra arguments to l10n-repack.py. I have a small patch that fixes it.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
CC'ing Mike in case he wants to take this one too :)
|
||
Updated•10 years ago
|
Attachment #8590787 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8590787 [details] [diff] [review]
Fix - v1
Approval Request Comment
[Feature/regressing bug #]: Feature
[User impact if declined]: Needed for Thunderbird 38 + Lightning
[Describe test coverage new/current, TreeHerder]: None yet, but as long as this variable is undefined it will be no different than before.
[Risks and why]: no known risks
[String/UUID change made/needed]: none
Attachment #8590787 -
Flags: approval-mozilla-beta?
Attachment #8590787 -
Flags: approval-mozilla-aurora?
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8590787 [details] [diff] [review]
Fix - v1
Beta+ Aurora+
Attachment #8590787 -
Flags: approval-mozilla-beta?
Attachment #8590787 -
Flags: approval-mozilla-beta+
Attachment #8590787 -
Flags: approval-mozilla-aurora?
Attachment #8590787 -
Flags: approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
|
||
Comment 7•10 years ago
|
||
status-firefox39:
--- → fixed
|
|
||
Comment 8•10 years ago
|
||
status-firefox38:
--- → fixed
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•