Closed
Bug 1153431
Opened 10 years ago
Closed 10 years ago
[Customizer] Add "Copy Node" feature
Categories
(Firefox OS Graveyard :: Gaia::Customizer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: justindarc, Assigned: justindarc)
References
Details
(Whiteboard: [spark])
Attachments
(1 file)
In order to improve efficiency when making DOM changes in the Customizer, we should offer the user a "Copy Node" option that behaves similarly to "Move Node" but also gives the user the ability to edit the copied HTML before inserting it in the DOM. This would allow for the user to be able to create new instances of complex pieces of UI such as custom buttons or dialog/modal boxes.
Assignee | ||
Updated•10 years ago
|
Blocks: spark-customizer
Assignee | ||
Comment 1•10 years ago
|
||
Bulk update to set the correct component and whiteboard.
Component: Gaia → Gaia::Customizer
Whiteboard: [spark]
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jdarcangelo
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8602330 -
Flags: review?(drs)
Comment 3•10 years ago
|
||
Comment on attachment 8602330 [details]
pull-request (master)
Looks good. I'm happy to see this change. I left some both small and general comments on the PR.
Attachment #8602330 -
Flags: review?(drs) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Landed on master:
https://github.com/fxos/customizer/commit/22d5c218973038104530d2fbb9259b8223537882
Made some of the suggested changes. Held off on doing some of the refactoring you suggested since it involves DRYing up the *generated* code and not the actual code itself. There may be a better way to do the code generation using templates and I'd rather give some more thought to this.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•