Closed Bug 1153503 Opened 10 years ago Closed 10 years ago

Enable push notifications on Nightly / DevTools

Categories

(Core :: DOM: Notifications, defect)

Product:
Core
Component:
DOM: Notifications
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- disabled

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file)

enable_push
(deleted), patch
nsm
: review+
Details | Diff | Splinter Review
No description provided.
Depends on: 1137245, 1132436
Removing 1132436, 1137245. These are bugs in sw proper, not with the push impl.
No longer depends on: 1132436, 1137245
Attached patch enable_push (deleted) — — Splinter Review
Attachment #8596611 - Flags: review?(nsm.nikhil)
https://hg.mozilla.org/mozilla-central/rev/aca9e40788af
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Release Note Request (optional, but appreciated) [Why is this notable]: Push notifications seems noteworthy. [Suggested wording]: Implemented Push API [Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
For the release notes, I can link this to https://developer.mozilla.org/en-US/docs/Web/API/Push_API. That has a big "TBD" at the top. Doug, is there a better post or page we could use or do you think this is good enough? There is a landing page planned in bug 1153501, too.
relnote-firefox: ? → 40+
Flags: needinfo?(dougt)
overholt tells me that this is actually disabled/broken in 40. I have removed the relnote from 40. We can note this when the feature moves to Aurora.
relnote-firefox: 40+ → ?
(In reply to Liz Henry (:lizzard) from comment #6) > For the release notes, I can link this to > https://developer.mozilla.org/en-US/docs/Web/API/Push_API. That has a big > "TBD" at the top. Doug, is there a better post or page we could use or do > you think this is good enough? > > There is a landing page planned in bug 1153501, too. As an FYI, I am now working on completing the MDN Push API reference. I should have the landing page sorted out in the next couple of days, and the whole reference finished in a week or two.
Flags: needinfo?(dougt)
Updating the flag to reflect the current status.
status-firefox40: fixed → disabled
Based on comment #7, should we re-open this bug? Or is it indeed resolved->fixed? I came across it when reviewing bugs that need to be release noted for Firefox41 (Aurora).
Flags: needinfo?(overholt)
Flags: needinfo?(lmandel)
Nikhil and Kit were hoping to ship in 41 but I don't know if that happened.
Flags: needinfo?(overholt)
Flags: needinfo?(nsm.nikhil)
Flags: needinfo?(lmandel)
Flags: needinfo?(kcambridge)
It doesn't look like this landed but maybe we're planning an uplift?
We didn't ship Push in 41, unfortunately...bug 1153504 and bug 1153500 didn't make it in time. We talked about uplifting the icon, but the push quota work is chunkier. Maybe it's best to wait until 42?
Flags: needinfo?(kcambridge)
(In reply to Kit Cambridge [:kitcambridge] from comment #13) > Maybe it's best to wait until 42? Seems safest to me but you and nsm should consider the risk/reward after bug 1153504 and bug 1153500 have landed.
Flags: needinfo?(nsm.nikhil)
waiting until the major 42 release is fine, but i would prefer 41 obviously!
release note flag moved to bug 1153499.
relnote-firefox: ? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: