Closed Bug 1153658 Opened 9 years ago Closed 9 years ago

browser_aboutperformance.js, browser_AddonWatcher.js, and browser_compartments.js are going to permafail when Gecko 40 merges to Aurora

Categories

(Toolkit :: Performance Monitoring, defect)

defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla40
Tracking Status
firefox40 --- verified

People

(Reporter: RyanVM, Assigned: Yoric)

References

Details

Attachments

(3 files)

+++ This bug was initially created as a clone of Bug #1153657 +++

WTH is with all the browser_compartments.js logspam, BTW?

https://treeherder.mozilla.org/logviewer.html#?job_id=6440443&repo=try
Flags: needinfo?(dteller)
Attached file browser_AddonWatcher.js log (deleted) —
Thanks for spotting this. I'll fix this with bug 1153657.

browser_compartments checks that the real-time performance data is updated correctly, is monotonic, etc. so it needs to check many things every few milliseconds. I suppose I could make the logs silent in case of success. Would this be useful?
Flags: needinfo?(dteller) → needinfo?(ryanvm)
Reducing 4MB of logspam sounds useful, yes.
Flags: needinfo?(ryanvm)
This patch will handle the logspam.
Keywords: checkin-needed
Whiteboard: [leave open]
https://hg.mozilla.org/integration/fx-team/rev/e94753b73400
Keywords: checkin-needed
Whiteboard: [leave open] → [leave open][fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Target Milestone: --- → mozilla40
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: