Closed
Bug 1153737
Opened 10 years ago
Closed 10 years ago
Remove unnecessary uses of mozilla::pkix::ScopedPtr outside of mozilla::pkix
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: briansmith, Assigned: briansmith)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8591521 -
Flags: review?(dkeeler)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8591521 [details] [diff] [review]
less-ScopedPtr.patch
Review of attachment 8591521 [details] [diff] [review]:
-----------------------------------------------------------------
Great! r=me
::: security/apps/AppSignatureVerification.cpp
@@ +11,1 @@
> #include "mozilla/RefPtr.h"
nit: if you feel like it, maybe put this #include in the right order as well?
Attachment #8591521 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
(In reply to David Keeler [:keeler] (use needinfo?) from comment #3)
> ::: security/apps/AppSignatureVerification.cpp
> @@ +11,1 @@
> > #include "mozilla/RefPtr.h"
>
> nit: if you feel like it, maybe put this #include in the right order as well?
I sorted all the includes in that file before pushing this:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0511335a89fd
Thanks for the quick review turnaround!
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•