Closed Bug 1153800 Opened 9 years ago Closed 9 years ago

Store the thumbnails associated with context as a data uri instead of a url

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla41
Iteration:
41.1 - May 25

People

(Reporter: standard8, Assigned: mikedeboer)

References

Details

(Whiteboard: [context][fixed by bug 1162903])

Attachments

(3 files)

Currently we're storing the thumbnails associated with context as a simple url.

The architecture calls for this to be stored as a data uri - this seems reasonable as it'd prevent issues with the website changing/removing images once someone had added them to a room.

https://wiki.mozilla.org/Loop/Architecture/Context#Format_of_context.value

RT has also said that we probably want to switch to favicons only, so doing that here as well might make it simpler.
Flags: firefox-backlog+
Rank: 8
Whiteboard: [context]
Rank: 8 → 6
Please let's move to Favicons only.
I copy Sevaan so he's aware - we discussed and it's his preference too.
I've just taken a look at this. Since we're switching to favicons only, we could go simpler on the document title, and just get the title of the current tab.

Mike/Jared, do you think we should:

a) update PageMetaData to also handle favicons, or
b) just get the favicon from the favicon service and use the current document title

?
Attached image Panel w/ Favicon Only (deleted) —
Note, it says "Let's talk about", not "Let's talk about this page".
Attached image Conversation Window w/ Favicon Only (deleted) —
Height of box with contextual information grows if page title wraps.
Attached image LinkClicker w/ Favicon Only (deleted) —
Note: Contextual information is left-aligned, not centered.
Blocks: 1162903
No longer blocks: 1115341
Assignee: nobody → mdeboer
Iteration: --- → 41.1 - May 25
Fixed by bug 1162903.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [context] → [context][fixed by bug 1162903]
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: