Closed
Bug 1154101
Opened 10 years ago
Closed 10 years ago
Remove PushMarkStack
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Now that PushMarkStack and GCMarker::traverse are equivalent, we can collapse them.
Attachment #8591977 -
Flags: review?(sphink)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8591977 [details] [diff] [review]
8_pushmarkstack_into_traverse-v0.diff
Review of attachment 8591977 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/gc/Marking.cpp
@@ +476,5 @@
> +
> +// The default traversal calls out to the fully generic traceChildren function
> +// to visit the child edges. In the absense of other traversal mechanisms, this
> +// function will rapidly grow the stack past its bounds and crash the process.
> +// Thus, this generic tracing should only be used in cases where
Cases where what?
|
Assignee | |
Comment 2•10 years ago
|
||
Finish the comment I was working on.
Assignee: nobody → terrence
Attachment #8591977 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8591977 -
Flags: review?(sphink)
Attachment #8591979 -
Flags: review?(sphink)
|
||
Updated•10 years ago
|
Attachment #8591979 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•