Closed
Bug 1154311
Opened 10 years ago
Closed 7 years ago
Drawing tiled images on OS X is too slow
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: jrmuizel, Assigned: mchang)
References
(Blocks 1 open bug)
Details
(Whiteboard: gfx-noted)
Attachments
(1 file, 9 obsolete files)
|
(deleted),
patch
|
mchang
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mchang
Status: NEW → ASSIGNED
Whiteboard: gfx-noted
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Blocks: paint-fast
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
|
Assignee | |
Comment 5•10 years ago
|
||
We have upwards to 1.5 seconds here - https://dxr.mozilla.org/mozilla-central/source/gfx/2d/DrawTargetCG.cpp?from=DrawTargetCG.cpp&case=true#933
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8592921 -
Attachment is obsolete: true
Attachment #8592924 -
Attachment is obsolete: true
Attachment #8592925 -
Attachment is obsolete: true
Attachment #8592926 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•10 years ago
|
||
|
|
Assignee | |
Comment 8•10 years ago
|
||
Each call to CGContextDrawTiledImage is actually fine, but to draw the image, we call it CGContextDrawTiledImage with the size of the rect multiple times.
|
|
Assignee | |
Comment 9•10 years ago
|
||
Just to not let this bitrot.
Attachment #8592259 -
Attachment is obsolete: true
Attachment #8592950 -
Attachment is obsolete: true
Attachment #8592986 -
Attachment is obsolete: true
Attachment #8592987 -
Attachment is obsolete: true
Attachment #8596207 -
Flags: review?(jmuizelaar)
|
Reporter | |
Comment 10•10 years ago
|
||
Comment on attachment 8596207 [details] [diff] [review]
Use CGContextDrawTiledImage on OS X
I beleive this call might have some issues on older versions of OS X. I'll see if I can dig them up.
Flags: needinfo?(jmuizelaar)
|
|
Reporter | |
Comment 11•10 years ago
|
||
Comment on attachment 8596207 [details] [diff] [review]
Use CGContextDrawTiledImage on OS X
Review of attachment 8596207 [details] [diff] [review]:
-----------------------------------------------------------------
It was broken Leopard.
Attachment #8596207 -
Flags: review?(jmuizelaar) → review+
|
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(jmuizelaar)
|
|
Assignee | |
Comment 12•10 years ago
|
||
Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=f512088cb119
One reftest failure
|
|
Assignee | |
Updated•9 years ago
|
|
|
Assignee | |
Comment 13•9 years ago
|
||
Carrying r+, unbitrotted.
Also seems to pass try now - https://treeherder.mozilla.org/#/jobs?repo=try&revision=99a6c60e16cc
Attachment #8596207 -
Attachment is obsolete: true
Attachment #8632195 -
Flags: review+
|
|
Assignee | |
Comment 14•7 years ago
|
||
Closing as won't fix for old bugs.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•