Comment on attachment 8592326 [details] [diff] [review] Synchronously record feature status Review of attachment 8592326 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/src/gfxCrashReporterUtils.cpp @@ +70,2 @@ > public: > + NS_IMETHOD Run() { Nit: override @@ +74,5 @@ > // leaked 1 instance of nsTArray_base with size 8 bytes > // leaked 7 instances of nsStringBuffer with size 8 bytes each (56 bytes total) > // So this is a work-around using a pointer, and using a nsIObserver to deallocate on xpcom shutdown. > // Yay for fighting bloat. > + nsCOMPtr<nsIObserverService> observerService = mozilla::services::GetObserverService(); Please MOZ_ASSERT that this runs on the main thread. @@ +86,1 @@ > } This whole block is no-op, please remove it and the rv variable.