Closed
Bug 1154518
Opened 9 years ago
Closed 9 years ago
Conflicting messages about telemetry
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: ekr, Assigned: Dexter)
References
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Dexter
:
review+
lmandel
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
I have telemetry turned off in: about:preferences#advanced However about:telemetry says: "Telemetry is enabled." That leaves me confused.
Reporter | ||
Comment 1•9 years ago
|
||
Reporter | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
I was able to reproduce the issue: this only happens when both FHR and Telemetry are enabled and FHR is then disabled (this should automatically disable Telemetry as well). Apparently, the line at [1] is not triggering the preference change even though the checkbox gets unticked. [1] - https://hg.mozilla.org/mozilla-central/annotate/de27ac2ab94f/browser/components/preferences/in-content/advanced.js#l278
Flags: needinfo?(alessio.placitelli)
Reporter | ||
Comment 4•9 years ago
|
||
So you mean that even though we tell the user in the interface that they have disabled telemetry we are actually reporting back? That seems like a fairly seriously issue.
Assignee | ||
Comment 5•9 years ago
|
||
This patch manually sets the telemetry.enabled preference when FHR is being unticked.
Assignee | ||
Updated•9 years ago
|
Attachment #8592835 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Eric Rescorla (:ekr) from comment #4) > So you mean that even though we tell the user in the interface that they > have disabled telemetry we are actually reporting back? That seems like a > fairly seriously issue. Reporting itself is controlled by the Health Report setting.
Comment 7•9 years ago
|
||
Comment on attachment 8592835 [details] [diff] [review] bug1154518.patch Review of attachment 8592835 [details] [diff] [review]: ----------------------------------------------------------------- Nice and simple, with tests - excellent, thanks for the patch!
Attachment #8592835 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 8•9 years ago
|
||
Should probably consider uplifting something this simple. That said, this would never have continued to show like this after a restart and/or reopening the preferences... are we sure this is the issue that :ekr was running into?
Assignee: nobody → alessio.placitelli
Status: NEW → ASSIGNED
Comment 9•9 years ago
|
||
Eric, is your profile still in this state? What's the state of the preference in about:config ?
Flags: needinfo?(ekr)
Comment 10•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #8) > That said, this would never have continued to show like this after a restart > and/or reopening the preferences... are we sure this is the issue that :ekr > was running into? Hmm... unless this code manually unchecks the checkbox every time the prefs are opened, which might be the case? :-\
Assignee | ||
Comment 11•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #8) > Should probably consider uplifting something this simple. Yes, I'll try-push this and try uplifting. > That said, this would never have continued to show like this after a restart > and/or reopening the preferences... are we sure this is the issue that :ekr > was running into? I'm fairly confident that's the issue, as I was able to reproduce it locally: the state of the preference doesn't change in about:config if you follow the steps in comment 3.
Assignee | ||
Comment 12•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2c5fa62a87c6
Assignee | ||
Comment 13•9 years ago
|
||
I've changed the commit message (added the reviewer).
Attachment #8592835 -
Attachment is obsolete: true
Attachment #8592857 -
Flags: review+
Reporter | ||
Comment 14•9 years ago
|
||
Gijs Unfortunately, I reset it from about:telemetry
Flags: needinfo?(ekr)
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 16•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad181e1e0b53
Keywords: checkin-needed
Comment 17•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ad181e1e0b53
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•9 years ago
|
status-firefox38:
--- → affected
status-firefox39:
--- → affected
Comment 18•9 years ago
|
||
Comment on attachment 8592857 [details] [diff] [review] bug1154518.patch Approved for Aurora. For approval request see bug 1139460 comment 42. For approval comments see bug 1139460 comment 43. Dexter - 38 is marked as affected. This is a simple patch. Do you want to nom this for uplift to Beta as well?
Flags: needinfo?(alessio.placitelli)
Attachment #8592857 -
Flags: approval-mozilla-aurora+
Comment 19•9 years ago
|
||
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #18) > Dexter - 38 is marked as affected. This is a simple patch. Do you want to > nom this for uplift to Beta as well? I assumed that it is too late. If we can take this, let's do it.
Flags: needinfo?(alessio.placitelli)
Comment 20•9 years ago
|
||
Comment on attachment 8592857 [details] [diff] [review] bug1154518.patch Approval Request Comment [Feature/regressing bug #]: FHR/Telemetry unification, bug 1075055. [User impact if declined]: Telemetry enabled state doesn't match the settings shown in preferences. [Describe test coverage new/current, TreeHerder]: Manually verified & added automated test-coverage. [Risks and why]: Low-risk, just explicitly setting prefs to match the displayed state. [String/UUID change made/needed]: None.
Attachment #8592857 -
Flags: approval-mozilla-beta?
Comment 22•9 years ago
|
||
Comment on attachment 8592857 [details] [diff] [review] bug1154518.patch [Triage Comment] Sure, should be in 38 beta 8
Attachment #8592857 -
Flags: approval-mozilla-beta? → approval-mozilla-release+
Updated•9 years ago
|
status-firefox38.0.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•