Closed
Bug 1154703
Opened 10 years ago
Closed 9 years ago
startup crash in mozilla::layers::CompositorD3D11::Initialize() with nvdxgiwrap
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
People
(Reporter: kairo, Assigned: jrmuizel)
Details
(Keywords: crash, Whiteboard: [gfx-noted])
Crash Data
Attachments
(2 files)
(deleted),
patch
|
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-release+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jrmuizel
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
lmandel
:
approval-mozilla-release+
lmandel
:
approval-mozilla-esr38+
|
Details | Diff | Splinter Review |
[Tracking Requested - why for this release]:
This bug was filed from the Socorro interface and is
report bp-e1b21510-7d02-4166-a5db-856232150415.
=============================================================
Stack:
0 xul.dll mozilla::layers::CompositorD3D11::Initialize() gfx/layers/d3d11/CompositorD3D11.cpp
1 xul.dll mozilla::layers::CompositorParent::InitializeLayerManager(nsTArray<mozilla::layers::LayersBackend> const&) gfx/layers/ipc/CompositorParent.cpp
2 xul.dll mozilla::layers::CompositorParent::AllocPLayerTransactionParent(nsTArray<mozilla::layers::LayersBackend> const&, unsigned __int64 const&, mozilla::layers::TextureFactoryIdentifier*, bool*) gfx/layers/ipc/CompositorParent.cpp
GFX Adapters:
0x8086 0x0046 846 84.685 %
Intel Corporation 3150 Intel Media Accelerator 3150 144 14.414 %
Intel Corporation Intel G33 Intel(R) G33 chipset GMA3100 video Driver 4 0.400 %
[and a few others with single hits]
This startup crash isn't there in any significant volume in 37 but is present visibly in 38 beta. We should solve it before it hits us on release.
I'm seeing a few intel gfx driver crashes in this triage period. Is this something you're aware of in the TO office?
Flags: needinfo?(milan)
Whiteboard: [gfx-noted]
All of these are dual GPU Intel+Nvidia, and only Win7 and Win7SP1.
This started on Aurora in 20150403004008, which was the day that the typo fix for bug 1137716 landed there. From a quick spot-check, all of the AdapterDriverVersion2 appear to be within the blocklist range.
So did the blocklisting just move the crash to a different place?
Flags: needinfo?(jmuizelaar)
Assignee | ||
Comment 4•10 years ago
|
||
38 crashes on the machine that I have of this character. 37 does not.
Flags: needinfo?(jmuizelaar)
Comment 5•10 years ago
|
||
Jeff, any idea how we could progress on this? Thanks
Flags: needinfo?(jmuizelaar)
Assignee | ||
Comment 7•10 years ago
|
||
So dxgiFactory is NULL probably because the nvidia driver is screwing with things.
Assignee | ||
Comment 8•10 years ago
|
||
I think this is probably caused by bug 1147728. We should probably invest in WARP blacklisting. In this case we can probably block WARP if nvdxgi wrap is loaded.
Comment 9•10 years ago
|
||
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #9)
> Try:
> https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/
> bschouten@mozilla.com-e445cf5edb66
This build still crashes
Summary: startup crash in mozilla::layers::CompositorD3D11::Initialize() → startup crash in mozilla::layers::CompositorD3D11::Initialize() with nvdxgiwrap
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jmuizelaar
Updated•10 years ago
|
Flags: needinfo?(milan)
Comment 11•10 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)
> (In reply to Bas Schouten (:bas.schouten) from comment #9)
> > Try:
> > https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/
> > bschouten@mozilla.com-e445cf5edb66
>
> This build still crashes
Can you take the patch and look at where this particular build crashes? I'm curious.
Updated•10 years ago
|
Flags: needinfo?(jmuizelaar)
Comment 12•10 years ago
|
||
Comment 13•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 14•10 years ago
|
||
Jeff, please fill the uplift request. Thanks!
Assignee | ||
Comment 15•10 years ago
|
||
Approval Request Comment
[Feature/regressing bug #]: bug 1147728
[User impact if declined]: Startup crash
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Small patch, low risk. Should cause us to the same path as we do on 37
Flags: needinfo?(jmuizelaar)
Attachment #8598724 -
Flags: approval-mozilla-beta?
Attachment #8598724 -
Flags: approval-mozilla-aurora?
Comment 16•10 years ago
|
||
Comment on attachment 8598724 [details] [diff] [review]
546210eeaf4a
[Triage Comment]
Should be in 38 beta 9
Attachment #8598724 -
Flags: approval-mozilla-release+
Attachment #8598724 -
Flags: approval-mozilla-beta?
Attachment #8598724 -
Flags: approval-mozilla-aurora?
Attachment #8598724 -
Flags: approval-mozilla-aurora+
Comment 17•10 years ago
|
||
Comment 18•10 years ago
|
||
Comment 19•10 years ago
|
||
status-firefox38.0.5:
--- → fixed
Reporter | ||
Comment 20•10 years ago
|
||
Hrm, 38.0b9 should have this patch, but it still crashes with this signature. :(
Comment 21•9 years ago
|
||
In early 38.0 release data this crash is huge volume (more than 3x OOM|small). ni? to Lawrence as a heads up.
(In reply to Pulsebot from comment #12)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/546210eeaf4a
The file to block should be nvdxgiwrap.dll, not nvdxgiwrapper.dll.
Status: RESOLVED → REOPENED
Flags: needinfo?(lmandel)
Resolution: FIXED → ---
Comment 22•9 years ago
|
||
Attachment #8604939 -
Flags: review?(jmuizelaar)
Attachment #8604939 -
Flags: review?(bas)
Assignee | ||
Updated•9 years ago
|
Attachment #8604939 -
Flags: review?(jmuizelaar) → review+
Comment 23•9 years ago
|
||
Reporter | ||
Comment 24•9 years ago
|
||
[Tracking Requested - why for this release]:
We should track this for all current releases (not nominating for 41, as it hopefully is fixed once inbound merges to central).
dmajor, can you please request uplift to all channels, aurora/beta/release?
status-firefox41:
--- → affected
tracking-firefox38.0.5:
--- → ?
tracking-firefox39:
--- → ?
tracking-firefox40:
--- → ?
Target Milestone: mozilla40 → ---
Reporter | ||
Comment 25•9 years ago
|
||
[Tracking Requested - why for this release]:
Ah, probably ESR as well.
status-firefox-esr38:
--- → affected
tracking-firefox-esr38:
--- → ?
Comment 26•9 years ago
|
||
Comment on attachment 8604939 [details] [diff] [review]
Typo fix
I should point out that I am not an expert on this code. I'm just stepping in to fix the typo.
I think it's reasonable to expect this fix to work, but we don't have any firsthand experience on how the affected machines will react to it. I do agree that we should get this merged though, because it can't really make things any worse.
Approval Request Comment
[Feature/regressing bug #]: bug 1147728
[User impact if declined]: Persistent startup crash
[Describe test coverage new/current, TreeHerder]: none
[Risks and why]: see above
[String/UUID change made/needed]: none
Attachment #8604939 -
Flags: approval-mozilla-release?
Attachment #8604939 -
Flags: approval-mozilla-esr38?
Attachment #8604939 -
Flags: approval-mozilla-beta?
Attachment #8604939 -
Flags: approval-mozilla-aurora?
Comment 27•9 years ago
|
||
I'm agree with what David said in comment 26 but would still much prefer to verify the fix before building 38.0.1 to do our best to ensure that we don't end up in the same position after another release
Jeff, as per comment 10, you have a machine that crashes due to this bug. Can you reproduce the bug with Firefox 38? If so, can you try to apply the patch and ensure that this fix is good before we proceed to build 38.0.1?
Flags: needinfo?(lmandel) → needinfo?(jmuizelaar)
Assignee | ||
Comment 28•9 years ago
|
||
I can reproduce the bug with FF38. I tried this build: https://hg.mozilla.org/integration/mozilla-inbound/rev/0dc1b8aadb57 and it did not crash.
Flags: needinfo?(jmuizelaar)
Comment on attachment 8604939 [details] [diff] [review]
Typo fix
One review should be enough; there is no nvdxgiwrapper.dll, it should have been nvdxgiwrap.dll all along.
Attachment #8604939 -
Flags: review?(bas)
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Comment 31•9 years ago
|
||
Comment on attachment 8604939 [details] [diff] [review]
Typo fix
Correction to dll name. Simple change. So much damage. Approved for landing across the board.
Note that release is both 38.0.5 and 38.0. The 38.0 change will need to land on a relbranch.
Attachment #8604939 -
Flags: approval-mozilla-release?
Attachment #8604939 -
Flags: approval-mozilla-release+
Attachment #8604939 -
Flags: approval-mozilla-esr38?
Attachment #8604939 -
Flags: approval-mozilla-esr38+
Attachment #8604939 -
Flags: approval-mozilla-beta?
Attachment #8604939 -
Flags: approval-mozilla-beta+
Attachment #8604939 -
Flags: approval-mozilla-aurora?
Attachment #8604939 -
Flags: approval-mozilla-aurora+
Comment 32•9 years ago
|
||
Fx 40:
https://hg.mozilla.org/releases/mozilla-aurora/rev/8669967982be
Fx 39:
https://hg.mozilla.org/releases/mozilla-beta/rev/88503bc88c21
Fx 38.0.5 (default):
https://hg.mozilla.org/releases/mozilla-release/rev/fff54632eedd
Fx 38.0.1 (GECKO380_2015050320_RELBRANCH)
https://hg.mozilla.org/releases/mozilla-release/rev/d204dd3fd48b
ESR 38.1 (default):
https://hg.mozilla.org/releases/mozilla-esr38/rev/fd7049c777c8
ESR 38.0.1 (GECKO380esr_2015050513_RELBRANCH):
https://hg.mozilla.org/releases/mozilla-esr38/rev/c93359b413ac
Comment 33•9 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: Fixed a startup crash
[Suggested wording]: Fixed: Systems with first generation NVidia Optimus graphics cards may crash on start-up
[Links (documentation, blog post, etc)]:
relnote-firefox:
--- → 38+
Comment 34•9 years ago
|
||
Jeff, since you reproduced this locally, could you please verify this fix with:
Firefox 38.0.1 - ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/38.0.1-candidates/build1/win32/en-US/
Firefox 38.0.1 ESR - ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/38.0.1esr-candidates/build1/win32/en-US/
Flags: needinfo?(jmuizelaar)
Comment 36•9 years ago
|
||
Updating flags according to Comment 35.
Comment 37•9 years ago
|
||
The latest nvidia drivers 352.86, which were released today, mention having fixed a start-up crash in Firefox on Optimus systems. Not sure if it is referring to this bug, but I just wanted to throw it out there.
http://us.download.nvidia.com/Windows/352.86/352.86-win8-win7-winvista-desktop-release-notes.pdf
That's a good tip Trevor, we'll check if this fixes it without our patch, and we can then perhaps narrow the blocklisting.
You need to log in
before you can comment on or make changes to this bug.
Description
•