Georg Fritzsche [:gfritzsche] Assignee
	Description • 9 years ago

Bug 1149284 disabled test_TelemetrySession.js since end of May, which dropped under our radar and means we missed test-coverage for some changes.

This fixed toLocalTimeISOString() failures when re-enabling it.

	David Teller [:Yoric] - still alive but not very active
	Comment 1 • 9 years ago

Comment on attachment 8592813 [details] [diff] [review]
Fix toLocalTimeISOString()

Review of attachment 8592813 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetrySession.jsm
@@ +259,5 @@
>      + "T" + padNumber(date.getHours(), 2)
>      + ":" + padNumber(date.getMinutes(), 2)
>      + ":" + padNumber(date.getSeconds(), 2)
>      + "." + date.getMilliseconds()
> +    + sign(tzOffset) + padNumber(Math.abs(Math.floor(tzOffset / 60)), 2)

Are you sure it's `Math.abs(Math.floor(...))` and not `Math.floor(Math.abs(...))`?

	David Teller [:Yoric] - still alive but not very active
	Comment 3 • 9 years ago

Comment on attachment 8593397 [details] [diff] [review]
Fix toLocalTimeISOString()

Review of attachment 8593397 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Any chance you could add a test?

	Pulsebot
	Comment 4 • 9 years ago

https://hg.mozilla.org/integration/fx-team/rev/fe5714bb1a43

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 5 • 9 years ago

Checked as part of this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8782360b606

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/fe5714bb1a43

	Lawrence Mandel [:lmandel] (use needinfo)
	Comment 7 • 9 years ago

Comment on attachment 8593397 [details] [diff] [review]
Fix toLocalTimeISOString()

Approved for Aurora. For approval request see bug 1139460 comment 42. For approval comments see bug 1139460 comment 43.

	Georg Fritzsche [:gfritzsche] Assignee
	Comment 8 • 9 years ago

https://hg.mozilla.org/releases/mozilla-aurora/rev/3b81354f6a5b