Closed Bug 1154952 Opened 10 years ago Closed 10 years ago

Fix Gecko shutdown assertions, bugs, etc

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(3 files)

Remove extra free() calls on shutdown (v1)
(deleted), patch
snorp
: review+
Details | Diff | Splinter Review
Delete AndroidBridge on Gecko shutdown (v1)
(deleted), patch
snorp
: review+
Details | Diff | Splinter Review
Don't wait for sync event when Gecko is shutting down (v1)
(deleted), patch
snorp
: review+
Details | Diff | Splinter Review
Right now we run into some assertions, bugs, etc. when Gecko is shutting down.
The two free() calls free the same memory. That memory was also passed in as the data argument to GeckoStart, and the caller will again try to free that memory. We should just let the caller do the freeing.
Attachment #8593530 - Flags: review?(snorp)
AndroidBridge is never deleted right now. We should be good citizens and clean up.
Attachment #8593532 - Flags: review?(snorp)
The main thread could get stuck trying to wait for a nonexistent Gecko thread.
Attachment #8593533 - Flags: review?(snorp)
Comment on attachment 8593533 [details] [diff] [review] Don't wait for sync event when Gecko is shutting down (v1) Review of attachment 8593533 [details] [diff] [review]: ----------------------------------------------------------------- Woo!
Attachment #8593533 - Flags: review?(snorp) → review+
Attachment #8593532 - Flags: review?(snorp) → review+
Comment on attachment 8593530 [details] [diff] [review] Remove extra free() calls on shutdown (v1) Review of attachment 8593530 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, I found this too a while back when working on the headless patch. Thanks.
Attachment #8593530 - Flags: review?(snorp) → review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: