Closed Bug 1155084 Opened 10 years ago Closed 10 years ago

[Flame][Contacts]The string on title bar is missed in Contact settings view.

Categories

(Firefox OS Graveyard :: Gaia::L10n, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.5?, b2g-v2.2 unaffected, b2g-master verified)

VERIFIED FIXED
blocking-b2g 2.5?
Tracking Status
b2g-v2.2 --- unaffected
b2g-master --- verified

People

(Reporter: zikui.yang, Assigned: kgrandon)

References

Details

(Keywords: regression)

Attachments

(4 files)

[1.Description]: [Flame][v3.0][Contacts]Enter Contacts->Settings,you will find that there is no string on heading. Attchment:2015-04-16-00-11-17.png and logcat_0558.txt Happen time:5:59 [2.Testing Steps]: 1.Launch Contacts 2.Tap settings icon at top left to enter settings view. [3.Expected Result]: 2.The title bar should be shown normally. [4.Actual Result]: 2. There is no string on heading in Contact settings view. [5.Reproduction build]: Flame 2.2: [Unaffected] Build ID 20150415162504 Gaia Revision 89a94a8b9c9087da916751697a61ba15bc0688c3 Gaia Date 2015-04-15 20:05:38 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/20e92b626530 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Flame 3.0:[Affected] Build ID 20150415160205 Gaia Revision 777d01f4a2c7b41c4b02e3cf87715714ccc0590b Gaia Date 2015-04-15 17:20:09 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/53ceefb0e1c8 Gecko Version 40.0a1 Device Name flame Firmware(Release) 4.4.2 [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: Free Test
Attached image 2015-04-16-00-11-17.png (deleted) —
Attached file logcat_0558.txt (deleted) —
[Blocking Requested - why for this release]: Visible regression on a well-used window. Likely due to bug 1066347. QA wanted to back it out locally and see if the string is back.
blocking-b2g: --- → 3.0?
Keywords: qawanted
I have confirmed that locally reverting the patch on bug 1066347 comment 7, the bug no longer reproduces. Contacts Settings header is correctly displayed after reverting.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: qawantedregression
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
The reason for this bug is that contacts/index.html is trying to use a string "settings" defined in dialer/locales/dialer.properties and not linked from contacts. W/Communications( 2919): Content JS WARN: L10nError: "settings" not found in en-US in app://communications.gaiamobile.org/contacts/index.html W/Communications( 2919): at reportMissingEntity (app://communications.gaiamobile.org/shared/js/l10n.js:2103:9)
Assignee: nobody → kgrandon
Comment on attachment 8601611 [details] [gaia] KevinGrandon:bug_1155084_contacts_settings_heading > mozilla-b2g:master Francisco or Zibi (since this is localization and caused by an l10n patch) - could either of you review this? I'm also updating the file to replace some tab characters with spaces at the same time for consistency. Thanks!
Attachment #8601611 - Flags: review?(gandalf)
Attachment #8601611 - Flags: review?(francisco)
Attachment #8601611 - Flags: review?(gandalf) → review+
Comment on attachment 8601611 [details] [gaia] KevinGrandon:bug_1155084_contacts_settings_heading > mozilla-b2g:master Thanks. I don't think it's really necessary to involve Francisco in the review here, so going to clear the request to save on review overhead.
Attachment #8601611 - Flags: review?(francisco)
Going to move this to l10n to use autolander.
Component: Gaia::Contacts → Gaia::L10n
Keywords: checkin-needed
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Thanks folks for taking care of this that fast.
This issue verified successfully on flame 3.0 Flame 3.0: Build ID 20150507160204 Gaia Revision bc5bfa18f795919b56b952bbf3637c235d0e13dc Gaia Date 2015-05-07 13:18:34 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/5e02da1141d2 Gecko Version 40.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150507.193314 Firmware Date Thu May 7 19:33:24 EDT 2015 Bootloader L1TC000118D0
Status: RESOLVED → VERIFIED
Attached image verified_v3.0.png (deleted) —
Add verify screenshot.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: