Closed Bug 1155093 Opened 10 years ago Closed 9 years ago

[RTL][Notifications] Text is too close to the right edge of the screen in RTL

Categories

(Firefox OS Graveyard :: Gaia::System, defect, P3)

ARM
Gonk (Firefox OS)
defect

Tracking

(b2g-v2.2 affected, b2g-master affected)

RESOLVED WORKSFORME
Tracking Status
b2g-v2.2 --- affected
b2g-master --- affected

People

(Reporter: lulu.tian, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [2.2-nexus-5-l][systemsfe])

Attachments

(3 files)

Attached image low_battery.png (deleted) —
[1.Description]: [RTL][Flame v2.2][Nexus 5 v2.2][Notifications]The icon in the notification "Low Battery" is left-aligned, which causes that the text is too close to the edge of screen.. See attachment:low_battery.png [2.Testing Steps]: Prerequisite:Have the battery level less than 10% 1. Set system language as Arabic. 2. Plug in charger. 3. Unplug in charger. 4. Observe the "Low Battery" notification. [3.Expected Result]: 4. The battery icon should be right-aligned. [4.Actual Result]: 4. The battery icon is left-aligned, which causes that the text is too close to the edge of screen. [5.Reproduction build]: Device: Flame 2.2 (affected) Build ID 20150415162504 Gaia Revision 89a94a8b9c9087da916751697a61ba15bc0688c3 Gaia Date 2015-04-15 20:05:38 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/20e92b626530 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150415.201243 Firmware Date Wed Apr 15 20:12:52 EDT 2015 Bootloader L1TC000118D0 Device: Flame 3.0 (unaffected) Build ID 20150415160205 Gaia Revision 777d01f4a2c7b41c4b02e3cf87715714ccc0590b Gaia Date 2015-04-15 17:20:09 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/53ceefb0e1c8 Gecko Version 40.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150415.192055 Firmware Date Wed Apr 15 19:21:04 EDT 2015 Bootloader L1TC000118D0 Device: Nexus 5 2.2 (affected) Build ID 20150415162504 Gaia Revision 89a94a8b9c9087da916751697a61ba15bc0688c3 Gaia Date 2015-04-15 20:05:38 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/20e92b626530 Gecko Version 37.0 Device Name hammerhead Firmware(Release) 5.1 Firmware(Incremental) eng.cltbld.20150415.200855 Firmware Date Wed Apr 15 20:09:09 EDT 2015 Bootloader HHZ12f Device: Nexus 5 3.0 (unaffected) Build ID 20150415160205 Gaia Revision 777d01f4a2c7b41c4b02e3cf87715714ccc0590b Gaia Date 2015-04-15 17:20:09 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/53ceefb0e1c8 Gecko Version 40.0a1 Device Name hammerhead Firmware(Release) 5.1 Firmware(Incremental) eng.cltbld.20150415.192113 Firmware Date Wed Apr 15 19:21:33 EDT 2015 Bootloader HHZ12f [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: Free Test
QA Whiteboard: [rtl-impact]
Can we find the patch that fixed this issue?
Whiteboard: [2.2-nexus-5-l] → [2.2-nexus-5-l][systemsfe]
I was just about to comment the bug. Looking at UX specs, I don't see why the battery icon should be right-aligned. Was it ever? The way I see it, battery icon should be were it is, and text should be left aligned. I believe the issue here is just that the text is too close to the right side of the screen. Please correct me if I'm wrong though!
(In reply to Delphine Lebédel [:delphine - use need info] from comment #2) > I was just about to comment the bug. Looking at UX specs, I don't see why > the battery icon should be right-aligned. Was it ever? The way I see it, > battery icon should be were it is, and text should be left aligned. Sorry, I meant here "text should be right-aligned" > I believe the issue here is just that the text is too close to the right > side of the screen. Please correct me if I'm wrong though!
Priority: -- → P3
I've gone through UX specs once more, and I still don't see why the battery icon should be right aligned in this case. Changing the title to reflect this (sorry for the noise!)
Summary: [RTL][Notifications]The icon in the notification "Low Battery" is not right-aligned. → [RTL][Notifications] Text is too close to the right edge of the screen in RTL
Delphine, I think we can just check the unaffected branch and see how it behaves for comparison. Right now none of us have a low battery but I can check it tomorrow.
Attached image Flame 3.0 screenshot (deleted) —
Delphine, on v3.0 the battery icon placement is indeed mirrored and is displayed on the right. So if you still think what you described at comment 2 should be the behavior being upheld, then we don't have a window here because v3.0 behavior is NOT the expected behavior. See attached screenshot for current 3.0 behavior.
Flags: needinfo?(lebedel.delphine)
I honestly still don't see where/why per UX specs the location of the battery icon in this notification should be mirrored, unless this is some kind of exception. Ni on UX to confirm this.
Flags: needinfo?(lebedel.delphine) → needinfo?(firefoxos-ux-bugzilla)
I've spoken offline with Stephany. She confirms that according to 2.2 specs, the location of the battery icon should not be mirrored, and text should appear right-aligned. This might change in future versions. Keeping this bug open as the text position still needs to be improved. Sue: can you make sure that test cases reflect this (location of the battery icon not mirrored)?
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(lulu.tian)
Thanks for confirming the issue. Removing window wanted since we don't have a window here (v3.0 is not behaving as expected).
Flags: needinfo?(ktucker)
QA Whiteboard: [rtl-impact] → [rtl-impact][QAnalyst-Triage+]
Flags: needinfo?(ktucker)
(In reply to Delphine Lebédel [:delphine - use need info] from comment #8) > Sue: can you make sure that test cases reflect this (location of the battery > icon not mirrored)? Hi Delphine, Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/16210/
Flags: needinfo?(lulu.tian) → in-moztrap+
Attached image AriesKK_v2.5.png (deleted) —
This issue cannot be reproduced on latest FlameKK&AriesKK v2.5 build by the same STR in comment 0. Actual Result:The battery icon is right-aligned and the text is shown at left side of battery icon. See attachment:AriesKK_v2.5.png. Reproducing rate:0/10 But this issue can be reproduced on latest FlameKK v2.2 build. Actual Result: The battery icon is left-aligned, which causes that the text is too close to the edge of screen. Device:FlameKK v2.2 build (Affected) Build ID 20150818032504 Gaia Revision 335cd8e79c20f8d8e93a6efc9b97cc0ec17b5a46 Gaia Date 2015-08-14 19:06:41 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/c29970d16372 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150818.065127 Firmware Date Tue Aug 18 06:51:38 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device:FlameKK v2.5 build (Unaffected) Build ID 20150818150207 Gaia Revision 507ba38fb64b27f87d11f4104dfcc58448e12b1a Gaia Date 2015-08-18 10:50:12 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/2c272af993c23e803f6ea7798a812b0c8abfad4d Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150818.184156 Firmware Date Tue Aug 18 18:42:07 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device:AriesKK v2.5 build(Unaffected) Build ID 20150818005621 Gaia Revision 60489c1ff8c5d1633fc4837d4f8019623d4e1940 Gaia Date 2015-08-16 02:21:48 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/6ae3e9ff53b2bae8d95a90c9f25368fd81fa357e Gecko Version 43.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20150818.003312 Firmware Date Tue Aug 18 00:33:21 UTC 2015 Bootloader s1
QA Whiteboard: [rtl-impact][QAnalyst-Triage+] → [rtl-impact][QAnalyst-Triage+][MGSEI-Triage+]
Per comment 11 and this issue cannot be reproduced on latest FlameKK&AriesKK v2.5 build, so change status of the issue from new to worksforme.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: