Closed Bug 1155228 Opened 10 years ago Closed 10 years ago

Awful blurry fonts in popup windows and menus after landing patch from bug #1150376

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
40 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox37 --- unaffected
firefox38 + verified
firefox39 + verified
firefox40 + verified

People

(Reporter: Virtual, Assigned: bas.schouten)

References

Details

(Keywords: nightly-community, regression)

Attachments

(6 files)

good1.png
(deleted), image/png
Details
bad1.png
(deleted), image/png
Details
good2.png
(deleted), image/png
Details
bad2.png
(deleted), image/png
Details
Only use Basic OMTC when using WARP.
(deleted), patch
jrmuizel
: review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
Another situation of this issue
(deleted), image/jpeg
Details
I have seen this in today's nightly too (win32 build, Win 8.1 x64, All D2D1.1/DX11 stuff active, Nvidia GTX650, latest drivers).
Tracking for 40. Florin, can you have a look to see if this regression also affects 38 and 39 since we uplifted the patch in bug 1150376? We may just end up backing out that patch.
tracking-firefox40: ? → +
Flags: needinfo?(florin.mezei)
This doesn't look "blurry" to me, it just looks like the text hinting is different. Likely due to different rendering mechanism in use (no D2D/DWrite after the patch maybe?)
I talked to Bas about this. We're going to change this so that it only happens when using WARP.
Assignee: nobody → bas
Attached patch Only use Basic OMTC when using WARP. (deleted) β€” β€” Splinter Review
Attachment #8593559 - Flags: review?(jmuizelaar)
Attachment #8593559 - Flags: review?(jmuizelaar) → review+
It seems that 38 and 39 are not affected by this issue. Tested on Windows 7 64-bit with: - latest Aurora, build ID: 20150416004008; - Firefox 38 beta 5, build ID: 20150416143048.
status-firefox38: ? → unaffected
status-firefox39: ? → unaffected
Flags: needinfo?(florin.mezei)
On my machine this issue is like some characters is "broken". Windows7 and firefox nightly v40 x64 edition.
Attached image Another situation of this issue (deleted) β€”
https://hg.mozilla.org/mozilla-central/rev/84a83069abb5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Jeff, Bas, can we have an uplift request for this bug? (needed if we uplift 1150376) Thanks
tracking-firefox38: --- → +
Flags: needinfo?(jmuizelaar)
Flags: needinfo?(bas)
Comment on attachment 8593559 [details] [diff] [review] Only use Basic OMTC when using WARP. Approval Request Comment [Feature/regressing bug #]: 1150376 [User impact if declined]: Worse text rendering in popup menus [Describe test coverage new/current, TreeHerder]: On trunk for a day or two [Risks and why]: Low risk. We're just reverting to a path that that's already exercised.
Flags: needinfo?(jmuizelaar)
Attachment #8593559 - Flags: approval-mozilla-beta?
Attachment #8593559 - Flags: approval-mozilla-aurora?
Comment on attachment 8593559 [details] [diff] [review] Only use Basic OMTC when using WARP. Should be in 38 beta 6.
Attachment #8593559 - Flags: approval-mozilla-beta?
Attachment #8593559 - Flags: approval-mozilla-beta+
Attachment #8593559 - Flags: approval-mozilla-aurora?
Attachment #8593559 - Flags: approval-mozilla-aurora+
Confirming this fix on Windows 7 64-bit using latest Firefox Nightly, build ID: 20150419030206.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
QA Contact: cornel.ionce
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: